Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding VersionStream for gitaly-17.7 #38367

Merged
merged 3 commits into from
Dec 30, 2024
Merged

Adding VersionStream for gitaly-17.7 #38367

merged 3 commits into from
Dec 30, 2024

Conversation

octo-sts[bot]
Copy link
Contributor

@octo-sts octo-sts bot commented Dec 26, 2024

No description provided.

Copy link
Contributor Author

octo-sts bot commented Dec 26, 2024

Gen AI suggestions to solve the build error:

• Detected Error: FAIL Expected commit d06e4074586fd7760f55ab0080d5c74fc735d25f for v17.7.0, found 5b522da1812b5602308b964e9b04021431cd2773

• Error Category: Version

• Failure Point: git-checkout step in pipeline

• Root Cause Analysis: The commit hash specified in the melange YAML doesn't match the actual commit hash for the v17.7.0 tag in the Gitaly repository.

• Suggested Fix: Update the expected-commit hash in the git-checkout step:

  - uses: git-checkout
    with:
      repository: https://gitlab.com/gitlab-org/gitaly.git
      tag: v${{package.version}}
      expected-commit: 5b522da1812b5602308b964e9b04021431cd2773

• Explanation: The build is failing because the git-checkout step is expecting a specific commit hash, but the v17.7.0 tag points to a different commit. This is a safety check to ensure we're building from the expected source code. The fix updates the expected commit hash to match the actual commit that the tag points to.

• Additional Notes:

  • This type of mismatch often occurs when releases are re-tagged or when there are last-minute changes before a release
  • You can verify the correct commit hash using: git ls-remote https://gitlab.com/gitlab-org/gitaly.git v17.7.0
  • The commit hash verification is a security measure to ensure reproducible builds

• References:

Signed-off-by: Jason Hall <jason@chainguard.dev>
@imjasonh imjasonh enabled auto-merge (squash) December 30, 2024 18:44
@octo-sts octo-sts bot added the bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. label Dec 30, 2024
@imjasonh imjasonh merged commit 3b8cf77 into main Dec 30, 2024
13 of 14 checks passed
@imjasonh imjasonh deleted the gitaly-17.7 branch December 30, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated pr bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. service:version-stream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants