Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shadow/4.17.0 package update #38360

Closed
wants to merge 2 commits into from

Conversation

octo-sts[bot]
Copy link
Contributor

@octo-sts octo-sts bot commented Dec 25, 2024

Signed-off-by: wolfi-bot <121097084+wolfi-bot@users.noreply.github.com>
@octo-sts octo-sts bot added request-version-update request for a newer version of a package automated pr labels Dec 25, 2024
Copy link
Contributor Author

octo-sts bot commented Dec 25, 2024

Gen AI suggestions to solve the build error:

Based on the error output, I'll analyze and provide a solution:

• Detected Error: "can't find file to patch at input line 3... The text leading up to this was: |--- a/lib/alloc.h"

• Error Category: Configuration/Patch

• Failure Point: During the patch step in the pipeline, specifically when trying to apply fix-undefined-reference.patch

• Root Cause Analysis: The patch is failing because the path specified in the patch file doesn't match the source tree structure, or the patch file is trying to modify a file that doesn't exist at the expected location.

• Suggested Fix:

  1. Update the patch section in the YAML to include the -p1 strip option:
  - uses: patch
    with:
      patches: |
        fix-undefined-reference.patch \
        useradd-defaults.patch
      strip-components: 1
  1. Alternatively, verify the patch file paths match the source tree by:
  - uses: patch
    with:
      patches: |
        fix-undefined-reference.patch \
        useradd-defaults.patch
      use-git: true

• Explanation: The patch is failing because the path prefixes don't match. The -p1 strip option removes one level of directory prefix from the patch paths, which is commonly needed when patches are created from git repositories. Using use-git: true lets git handle the patch application which can be more forgiving with path matching.

• Additional Notes:

  • The source code is being extracted from a .tar.xz file which might have a different directory structure than what the patch expects
  • The patch appears to be trying to modify lib/alloc.h but can't find the correct path
  • Using git-style patch application can help handle path differences automatically

• References:

Signed-off-by: Batuhan Apaydin <batuhan.apaydin@chainguard.dev>
Copy link
Contributor Author

octo-sts bot commented Dec 29, 2024

Gen AI suggestions to solve the build error:

Based on the build error output, I'll analyze and provide a solution:

• Detected Error: rm: can't remove '/home/build/melange-out/shadow/usr/share/man/man1/groups.*': No such file or directory

• Error Category: Configuration

• Failure Point: Final cleanup step in the pipeline trying to remove man pages

• Root Cause Analysis: The build is failing because it's trying to remove a man page that doesn't exist. This is happening in the pipeline step that removes the groups man page to avoid conflicts with coreutils-doc package.

• Suggested Fix: Modify the pipeline step to make the rm command non-failing by adding the -f flag and checking if the file exists. Change this line:

From:

rm ${{targets.destdir}}/usr/share/man/man1/groups.*

To:

rm -f ${{targets.destdir}}/usr/share/man/man1/groups.* || true

• Explanation: The -f flag makes rm continue even if files don't exist, and the || true ensures the command succeeds even if rm returns a non-zero exit status. This is a common pattern in build systems when dealing with cleanup operations that may or may not need to happen.

• Additional Notes:

  • This is a non-critical error since it's just trying to clean up documentation files
  • The actual package functionality is not affected
  • The error occurs because the man page is already handled differently in the build process

• References:

@octo-sts octo-sts bot closed this Dec 31, 2024
Copy link
Contributor Author

octo-sts bot commented Dec 31, 2024

superseded by #38566

@octo-sts octo-sts bot deleted the wolfictl-8aced7d4-4dc1-4808-8df7-c91157bdcdee branch January 1, 2025 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated pr request-version-update request for a newer version of a package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants