Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kots/1.122.1 package update #38093

Closed
wants to merge 3 commits into from

Conversation

octo-sts[bot]
Copy link
Contributor

@octo-sts octo-sts bot commented Dec 20, 2024

Signed-off-by: wolfi-bot <121097084+wolfi-bot@users.noreply.github.com>
@octo-sts octo-sts bot added request-version-update request for a newer version of a package automated pr P1 This label indicates our scanning found High, Medium or Low CVEs for these packages. labels Dec 20, 2024
Copy link
Contributor Author

octo-sts bot commented Dec 20, 2024

Gen AI suggestions to solve the build error:

Let me analyze the build error and provide specific recommendations:

• Detected Error: Multiple SASS deprecation warnings, primarily:

Deprecation The legacy JS API is deprecated and will be removed in Dart Sass 2.0.0.
Deprecation Global built-in functions are deprecated and will be removed in Dart Sass 3.0.0.

• Error Category: Build Configuration

• Failure Point: Web assets compilation during make -C web deps lint build-kotsadm

• Root Cause Analysis:
The project is using deprecated SASS color functions and import syntax in its SCSS files. While these are currently warnings, they will become breaking errors in future SASS versions.

• Suggested Fix:

  1. Add a .sassrc.js configuration file in the web directory:
module.exports = {
  functions: { 
    implementation: require("sass")
  },
  includePaths: ["node_modules"]
}
  1. Update the SCSS color function calls in src/scss/variables.scss:
    Replace:
darken($color, 8%)  
lighten($color, 25%)

With:

color.adjust($color, $lightness: -8%)
color.adjust($color, $lightness: 25%)
  1. Update SASS imports to use @use instead of @import:
@use 'sass:color';
@use './variables' as *;

• Explanation:
The fixes modernize the SASS implementation to use the new module system and color functions, preventing future breaking changes when Dart Sass 2.0/3.0 are released. The build should complete without deprecation warnings.

• Additional Notes:

  • The warnings don't currently break the build but should be addressed proactively
  • The asset size warnings are separate and don't affect build success
  • Consider implementing code splitting to address the asset size warnings

• References:

@debasishbsws debasishbsws self-assigned this Dec 26, 2024
we are getting a network timeout while trying to fetch a package (@mui/icons-material) from the Yarn package registry.

Signed-off-by: Debasish Biswas <debasishbsws.dev@gmail.com>
Signed-off-by: Debasish Biswas <debasishbsws.dev@gmail.com>
@debasishbsws
Copy link
Member

already in the latest version

@debasishbsws debasishbsws deleted the wolfictl-7a14c253-1d47-4b70-8a11-20a3d5f7f685 branch December 30, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated pr P1 This label indicates our scanning found High, Medium or Low CVEs for these packages. request-version-update request for a newer version of a package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants