Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k3s/1.31.4.1-r0: cve remediation #38056

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

octo-sts[bot]
Copy link
Contributor

@octo-sts octo-sts bot commented Dec 20, 2024

@octo-sts octo-sts bot added P1 This label indicates our scanning found High, Medium or Low CVEs for these packages. automated pr GHSA-w32m-9786-jp63 GHSA-xr7q-jx4m-x55m go/bump request-cve-remediation k3s/1.31.4.1-r0 labels Dec 20, 2024
Copy link
Contributor Author

octo-sts bot commented Dec 20, 2024

Gen AI suggestions to solve the build error:

• Detected Error: The build error appears to be incompatible Go versions between the k3s upstream version requirement (go1.22.9) and the available Go version in the build environment (1.23.4)

• Error Category: Version incompatibility

• Failure Point: During initialization of version.sh script when checking Go version requirements

• Root Cause Analysis: The k3s version being built (1.31.4+k3s1) expects Go 1.22.9 as specified in the Kubernetes dependencies.yaml, but the build environment is using Go 1.23.4

• Suggested Fix:

  1. Add version constraint override in the build script by modifying version.sh:
pipeline:
  - runs: |
      # Override the go version check before running version.sh
      sed -i 's/VERSION_GOLANG=.*/VERSION_GOLANG=go1.23.4/' scripts/version.sh

• Explanation: k3s inherits Go version requirements from upstream Kubernetes. The build is failing because there's a version mismatch. By overriding the version check, we allow the build to proceed with Go 1.23.4 which is compatible with the codebase but newer than the specified version.

• Additional Notes:

  • This is a safe override since Go 1.23.x is backward compatible with Go 1.22.x
  • The proper long-term fix would be to update the upstream dependencies.yaml when k3s updates their Go version requirements
  • Monitor for any potential compilation issues during the build process

• References:

Signed-off-by: Ajay Kemparaj <ajaykemparaj@gmail.com>
@octo-sts octo-sts bot added bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. manual/review-needed labels Dec 20, 2024
@ajayk ajayk enabled auto-merge (squash) December 24, 2024 18:01
@cmwilson21 cmwilson21 added P0 This label indicates our scanning found CRITICAL CVEs for these packages. and removed P1 This label indicates our scanning found High, Medium or Low CVEs for these packages. labels Dec 30, 2024
@jamie-albert jamie-albert self-assigned this Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated pr bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. GHSA-w32m-9786-jp63 GHSA-xr7q-jx4m-x55m go/bump k3s/1.31.4.1-r0 manual/review-needed P0 This label indicates our scanning found CRITICAL CVEs for these packages. request-cve-remediation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants