Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spark-3.5-scala-2.13/3.5.4 package update #37961

Merged
merged 2 commits into from
Dec 23, 2024

Conversation

octo-sts[bot]
Copy link
Contributor

@octo-sts octo-sts bot commented Dec 20, 2024

Signed-off-by: wolfi-bot <121097084+wolfi-bot@users.noreply.github.com>
@octo-sts octo-sts bot added request-version-update request for a newer version of a package automated pr P1 This label indicates our scanning found High, Medium or Low CVEs for these packages. labels Dec 20, 2024
Copy link
Contributor Author

octo-sts bot commented Dec 20, 2024

Gen AI suggestions to solve the build error:

Based on the error output, I'll provide a specific analysis and solution:

• Detected Error:

patching file build/mvn
Hunk #1 FAILED at 56.
1 out of 2 hunks FAILED -- saving rejects to file build/mvn.rej

• Error Category: Configuration/Patch

• Failure Point: The patch application step failed specifically for the build/mvn file

• Root Cause Analysis:
The patch file mvn.patch is not aligning with the current source code, likely due to changes in the upstream Spark 3.5.4 codebase that modified the location or content of the targeted lines.

• Suggested Fix:

  1. Examine the current build/mvn file at line 56 and surrounding context
  2. Update the mvn.patch file to match the current file structure:
# Get the current file version
git show v3.5.4:build/mvn > build/mvn.current

# Generate a new patch
diff -u build/mvn.current build/mvn.desired > mvn.patch.new
  1. Or modify the patch to use fuzzy matching:
--- a/build/mvn
+++ b/build/mvn
@@ -53,6 +53,7 @@
+  # Add your changes here with correct context

• Explanation:
Patch failures typically occur when the context lines don't match the target file exactly. By regenerating the patch against the specific version we're targeting (3.5.4), we ensure proper alignment. The patch needs to be updated to match the exact file structure in the v3.5.4 tag.

• Additional Notes:

  • Consider using git apply --reject to see detailed rejection information
  • The make-distribution.sh patch applied successfully, so only the Maven patch needs updating
  • Version 3.5.4 might have reorganized the build scripts compared to previous versions

• References:

@debasishbsws debasishbsws self-assigned this Dec 23, 2024
… in this new version

Signed-off-by: Debasish Biswas <debasishbsws.dev@gmail.com>
@octo-sts octo-sts bot added bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. manual/review-needed labels Dec 23, 2024
@cpanato cpanato merged commit 7853ab6 into main Dec 23, 2024
13 of 14 checks passed
@cpanato cpanato deleted the wolfictl-d8b92c88-afc4-41f5-9e31-4cc2356bd436 branch December 23, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated pr bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. manual/review-needed P1 This label indicates our scanning found High, Medium or Low CVEs for these packages. request-version-update request for a newer version of a package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants