Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Package: pgadmin4(most popular and feature rich Open Source admin… #37339

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Aditvil-Dev
Copy link
Member

…istration and development platform for PostgreSQL)

Fixes:

Related:

Pre-review Checklist

For new package PRs only

  • This PR is marked as fixing a pre-existing package request bug
    • Alternatively, the PR is marked as related to a pre-existing package request bug, such as a dependency
  • REQUIRED - The package is available under an OSI-approved or FSF-approved license
  • REQUIRED - The version of the package is still receiving security updates
  • This PR links to the upstream project's support policy (e.g. endoflife.date)

For new version streams

  • The upstream project actually supports multiple concurrent versions.
  • Any subpackages include the version string in their package name (e.g. name: ${{package.name}}-compat)
  • The package (and subpackages) provides: logical unversioned forms of the package (e.g. nodejs, nodejs-lts)
  • If non-streamed package names no longer built, open PR to withdraw them (see WITHDRAWING PACKAGES)

For package updates (renames) in the base images

When updating packages part of base images (i.e. cgr.dev/chainguard/wolfi-base or ghcr.io/wolfi-dev/sdk)

  • REQUIRED cgr.dev/chainguard/wolfi-base and ghcr.io/wolfi-dev/sdk images successfully build
  • REQUIRED cgr.dev/chainguard/wolfi-base and ghcr.io/wolfi-dev/sdk contain no obsolete (no longer built) packages
  • Upon launch, does apk upgrade --latest successfully upgrades packages or performs no actions

For security-related PRs

  • The security fix is recorded in the advisories repo

For version bump PRs

  • The epoch field is reset to 0

For PRs that add patches

  • Patch source is documented

@Aditvil-Dev Aditvil-Dev marked this pull request as ready for review December 19, 2024 16:12
@Aditvil-Dev Aditvil-Dev added the approved-to-run A repo member has approved this external contribution label Dec 19, 2024
Copy link
Contributor

octo-sts bot commented Dec 19, 2024

Gen AI suggestions to solve the build error:

Based on the error message, I'll analyze and provide a solution:

• Detected Error: "ini.ShadowLoad(): key-value delimiter not found: development platform for PostgreSQL, the most advanced Open Source database in the world."

• Error Category: Configuration

• Failure Point: APK index generation step during package creation

• Root Cause Analysis: The package description contains newlines or formatting that's incompatible with the APK index format. The APK index requires description fields to be single-line entries.

• Suggested Fix:
Modify the package description in the YAML to be a single line without newlines:

package:
  name: pgadmin4-17
  version: "8.14"
  epoch: 0
  description: "pgAdmin is the most popular and feature rich Open Source administration and development platform for PostgreSQL, the most advanced Open Source database in the world."

• Explanation: The APK index format expects package metadata to follow a specific format where descriptions must be single-line entries. The current multi-line description is causing the index generation to fail because it can't properly parse the key-value pairs.

• Additional Notes:

  • APK index files use a specific format similar to INI files
  • Each field needs to be on a single line
  • The pipe operator (|) in YAML, while valid for multi-line strings, isn't compatible with the APK index format
  • This is a common issue when packaging for Alpine-based systems

• References:

Copy link
Contributor

octo-sts bot commented Dec 19, 2024

Gen AI suggestions to solve the build error:

Based on the build output, I don't actually see an error - the build appears to have completed successfully. The output shows the package was built, scanned for dependencies, and an APK was generated successfully.

Here's the analysis:

• Detected Error: None visible in the output provided. The build completed with:

wrote packages/x86_64/pgadmin4-17-8.14-r0.apk

• Error Category: N/A - Build succeeded

• Failure Point: N/A - No failure detected

• Root Cause Analysis: The build appears to have completed successfully, generating the expected APK package with dependencies scanned and SBOM generated

• Suggested Fix: No fix needed as the build succeeded

• Explanation: The output shows:

  1. All files were added to the package
  2. Dependencies were scanned
  3. SBOM was generated
  4. Final APK was created
  5. Index was updated

• Additional Notes:

  • The package was built successfully for x86_64 architecture
  • Runtime dependencies were correctly identified
  • Package size is 35740 bytes
  • All expected build steps completed

If you're seeing a different error in the CI system, please share that specific error message as the build output you've provided shows a successful build completion.

Would you be able to share the specific CI error message you're seeing? That would help me provide more targeted assistance.

Aditvil-Dev and others added 7 commits December 20, 2024 09:58
…istration and development platform for PostgreSQL)

Signed-off-by: Aditvil-Dev <aditya.tirmanwar@chainguard.dev>
Signed-off-by: Aditvil-Dev <aditya.tirmanwar@chainguard.dev>
Signed-off-by: Aditvil-Dev <aditya.tirmanwar@chainguard.dev>
Signed-off-by: Aditvil-Dev <aditya.tirmanwar@chainguard.dev>
Signed-off-by: Aditvil-Dev <aditya.tirmanwar@chainguard.dev>
Signed-off-by: Aditvil-Dev <aditya.tirmanwar@chainguard.dev>
Signed-off-by: RJ Sampson <rj.sampson@chainguard.dev>
@EyeCantCU EyeCantCU force-pushed the new-package_pgadmin4 branch from f23a092 to 91b0ae3 Compare December 20, 2024 17:24
@octo-sts octo-sts bot added the bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. label Dec 20, 2024
Signed-off-by: Aditvil-Dev <aditya.tirmanwar@chainguard.dev>
Signed-off-by: Aditvil-Dev <aditya.tirmanwar@chainguard.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-to-run A repo member has approved this external contribution bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants