Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotty/3.6.2 package update #36264

Merged
merged 3 commits into from
Dec 30, 2024
Merged

Conversation

octo-sts[bot]
Copy link
Contributor

@octo-sts octo-sts bot commented Dec 10, 2024

  • Switched the repository for building Dotty from https://github.com/lampepfl/dotty to https://github.com/scala/scala3. because these are just alias
  • Refactored the build process to use sbt dist/Universal/packageBin and updated the installation paths.
  • Properly Cleaned up unnecessary Windows batch files during the build process.
  • Moved scala-cli.jar to the correct directory to resolve issues.
  • Add bash as runtime dependency as scala scripts needs them
  • Added multiple tests**:
    • Verify binaries are installed and executable.
    • Compile and run a simple Scala program.
    • Compile and run a Scala program with multiple files.
    • Generate and verify Scaladoc documentation.

Signed-off-by: wolfi-bot <121097084+wolfi-bot@users.noreply.github.com>
@octo-sts octo-sts bot added request-version-update request for a newer version of a package automated pr labels Dec 10, 2024
Copy link
Contributor Author

octo-sts bot commented Dec 10, 2024

Gen AI suggestions to solve the build error:

• Detected Error:

[error] Expected ':'
[error] Not a valid key: pack (similar: package, packageDoc, packageSrc)
[error] dist/pack
[error]          ^

• Error Category: Build Configuration

• Failure Point: SBT command dist/pack in the pipeline step

• Root Cause Analysis: The SBT command syntax dist/pack is incorrect. The forward slash notation isn't valid for SBT task invocation. SBT uses slash syntax in project references, but tasks should use colon notation.

• Suggested Fix:
Modify the pipeline command from:

  - runs: |
      sbt dist/pack

to:

  - runs: |
      sbt "dist/package"

or

  - runs: |
      sbt dist:package

• Explanation:

  • SBT uses colon notation for task execution (project:task) not forward slashes
  • The dist project likely has a standard package task rather than pack
  • The corrected syntax follows standard SBT command structure
  • The quotation marks ensure proper argument parsing in the shell

• Additional Notes:

  • If a custom pack task is needed, it should be defined in the project's build.sbt
  • Consider checking the Dotty build documentation for the exact build command
  • Alternatively, look at the CI configuration in the Dotty repo for the correct build commands

• References:

@debasishbsws debasishbsws self-assigned this Dec 24, 2024
…l the thinkgs where it as before

Signed-off-by: Debasish Biswas <debasishbsws.dev@gmail.com>
@octo-sts octo-sts bot added the bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. label Dec 30, 2024
@debasishbsws debasishbsws marked this pull request as draft December 30, 2024 10:11
@debasishbsws
Copy link
Member

The application is broken, working on it.

The previous build was broken as the required jar files are either missing or misplaced. Also Move to the real scalla 3 repository to build dotty as previous one is just the alies of this one

Signed-off-by: Debasish Biswas <debasishbsws.dev@gmail.com>
@debasishbsws debasishbsws marked this pull request as ready for review December 30, 2024 11:50
@debasishbsws
Copy link
Member

Have no idea how to fix the CVEs

@cpanato cpanato merged commit b4cb9ee into main Dec 30, 2024
13 of 14 checks passed
@cpanato cpanato deleted the wolfictl-5aa28b2b-b71b-4d81-a231-82ade7ade505 branch December 30, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated pr bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. request-version-update request for a newer version of a package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants