Skip to content

extra sanity check on RSA decrypt argument #9445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+5 −2
Closed

extra sanity check on RSA decrypt argument #9445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion tests/api/test_rsa.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -822,7 +822,10 @@ int test_wc_RsaPublicEncryptDecrypt(void)
ExpectIntGE(wc_RsaPrivateDecrypt(cipher, cipherLenResult, plain, plainLen,
&key), 0);
ExpectIntEQ(XMEMCMP(plain, inStr, plainLen), 0);
/* Pass bad args - tested in another testing function.*/

/* Pass bad args - additionally tested in another testing function.*/
ExpectIntEQ(wc_RsaPrivateDecrypt(cipher, cipherLenResult, plain, inLen - 1,
&key), RSA_BUFFER_E);

WC_FREE_VAR(in, NULL);
WC_FREE_VAR(plain, NULL);
Expand Down
2 changes: 1 addition & 1 deletion wolfcrypt/src/rsa.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3638,7 +3638,7 @@ static int RsaPrivateDecryptEx(const byte* in, word32 inLen, byte* out,
word32 j;
int start = (int)((size_t)pad - (size_t)key->data);

for (j = 0; j < key->dataLen; j++) {
for (j = 0; j < key->dataLen && i < outLen; j++) {
signed char c;
out[i] = key->data[j];
c = (signed char)ctMaskGTE((int)j, start);
Expand Down