TLS EMS: Set haveEMS when we negotiate TLS 1.3 #8487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
julek-wolfssl
commented
Feb 21, 2025
julek-wolfssl
commented
- Move extended master secret testing to test_tls_ext.c
julek-wolfssl
force-pushed
the
zd/19391
branch
2 times, most recently
from
0ce4d25 to
2442bac
Compare
|
Retest this please: "hudson.remoting.RequestAbortedException exception:" |
dgarske
previously approved these changes
Mar 3, 2025
|
Rebased to master to fix merge conflicts. |
SparkiDev
approved these changes
Mar 4, 2025
|
Retest this please. History lost |
dgarske
approved these changes
Mar 6, 2025
dgarske
requested changes
Mar 6, 2025
| ExpectIntEQ(wolfSSL_get_error(ssl_c, -1), WOLFSSL_ERROR_WANT_READ); | ||
|
|
||
| ExpectNotNull(session = wolfSSL_get1_session(ssl_c)); | ||
| ExpectTrue(session->haveEMS); |
There was a problem hiding this comment.
--with-liboqs --enable-experimental --enable-opensslall --enable-crl --enable-sessioncerts --enable-aesctr --enable-rsapss --enable-keygen --enable-des3 CPPFLAGS="-DRSA_MAX_SIZE=8196 -DFP_MAX_BITS=16384 -DNO_OLD_TIMEVAL_NAME -DWOLFSSL_MYSQL_COMPATIBLE -DWOLFSSL_AES_DIRECT -DKEEP_OUR_CERT -DHAVE_AES_ECB -DWOLFSSL_NO_DEF_TICKET_ENC_CB -DHAVE_EX_DATA"
ERROR - tests/api/test_tls_ext.c line 73 failed with:
expected: session->haveEMS is true
result: session->haveEMS => FALSE
failed ( 0.00701)
ERROR - tests/api.c line 90675 failed with:
expected: Test failed```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.