ntp 4.2.8p17 additions #8324
Open
ntp 4.2.8p17 additions #8324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
julek-wolfssl
commented
Dec 31, 2024
julek-wolfssl
commented
- OBJ_sn2nid: use correct short names
- Add MD4 to EVP layer
- Add ntp 4.2.8p17 to tested versions
|
Depends on wolfSSL/osp#220 |
JacobBarthelmeh
requested changes
Jan 10, 2025
|
|
||
| /* Nginx uses this OpenSSL string. */ | ||
| if (XSTRCMP(sn, "prime256v1") == 0) | ||
| sn = "SECP256R1"; |
There was a problem hiding this comment.
Are we confident that this and also removing the check on WOLFSSL_*_NAME strings will not cause issues? Would prefer keeping the extra handling of those additional short names if possible.
There was a problem hiding this comment.
These extra names are not OpenSSL compliant. That is why I removed it to simplify the implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.