-
Notifications
You must be signed in to change notification settings - Fork 836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Coverage for hpke.c test case HAVE_CURVE448 using test.c #7570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgarske
requested changes
May 22, 2024
dgarske
requested changes
May 22, 2024
dgarske
requested changes
May 22, 2024
dgarske
approved these changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. I am assigning these HPKE test coverage PR's over to @cconlon to determine the best way to merge each interns work.
cconlon
approved these changes
May 23, 2024
aidangarske
pushed a commit
to aidangarske/wolfssl
that referenced
this pull request
May 23, 2024
4 tasks
jefferyq2
pushed a commit
to jefferyq2/wolfssl
that referenced
this pull request
Jun 9, 2024
Code Coverage for hpke.c test case HAVE_CURVE448 using test.c
jefferyq2
pushed a commit
to jefferyq2/wolfssl
that referenced
this pull request
Jun 9, 2024
Revert change from PR wolfSSL#7570
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Goal was to have code coverage for the HAVE_CURVE448 case in hpke.c, I achieved this by adding a new test case into test.c that hit those lines of code in hpke.c.