20231215-srtp-cleanup #7074
Merged
20231215-srtp-cleanup #7074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* in wolfssl/ssl.h, add missing arg names to wolfSSL_CTX_set_tlsext_use_srtp(), wolfSSL_set_tlsext_use_srtp(), and wolfSSL_export_dtls_srtp_keying_material(); * in wolfcrypt/src/kdf.c, call wc_AesFree if and only if wc_AesInit() succeeded; * in src/ssl.c:DtlsSrtpSelProfiles(), fix bugprone-inc-dec-in-conditions; * in tests/suites.c:execute_test_case(), fix several -Wdeclaration-after-statement and -Wmissing-field-initializers; * in wolfcrypt/test/test.c, fix a shiftTooManyBitsSigned warning in srtpkdf_test(), and fix a typo (kaSz/ksSz).
dgarske
approved these changes
Dec 15, 2023
|
retest this please. |
cconlon
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SRTP fixes:
wolfssl/ssl.h, add missing arg names towolfSSL_CTX_set_tlsext_use_srtp(),wolfSSL_set_tlsext_use_srtp(), andwolfSSL_export_dtls_srtp_keying_material();wolfcrypt/src/kdf.c, callwc_AesFreeif and only ifwc_AesInit()succeeded;src/ssl.c:DtlsSrtpSelProfiles(), fixbugprone-inc-dec-in-conditions;tests/suites.c:execute_test_case(), fix several-Wdeclaration-after-statementand-Wmissing-field-initializers;wolfcrypt/test/test.c, fix ashiftTooManyBitsSignedwarning insrtpkdf_test(), and fix a typo (kaSz/ksSz).tested with
wolfssl-multi-test.sh ... super-quick-checkwith--enable-srtpadded toENABLE_ALL_TEST_FLAGS.