Repository navigation
Sni examples - #644
Sni examples#644aidankeefe2022 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Valid fragmented or case-varied SNI requests can fail, and the documented abort policy contradicts its implementation.
3 open findings
What changed in this PR
Adds TLS 1.3 SNI client/server examples with virtual-host certificate selection and documentation.
Changes:
- Adds SNI client and multi-host server examples.
- Documents SNI policies, usage, and certificate validation.
- Adds integration coverage and ignores generated binaries.
| File | Description |
|---|---|
tls/server-tls-sni.c |
Implements SNI-based virtual hosting. |
tls/client-tls-sni.c |
Implements SNI requests and hostname validation. |
tls/README.md |
Documents building, policies, and usage. |
.github/examples-manifest.yml |
Adds an ECC virtual-host integration run. |
.gitignore |
Ignores the new binaries. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bd5ea03 to
8032ee7
Compare
8032ee7 to
3ebc54f
Compare
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #644
Scan targets checked: wolfssl-examples-src, wolfssl-examples-bugs
Coverage: 1 of 2 in-scope changed file(s) opened by the reviewer; not opened: tls/client-tls-sni.c
Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Reported findings require changes before merge.
Review tier: Lite
3ebc54f to
ac57716
Compare


No description provided.