Skip to content

Sni examples - #644

Draft
aidankeefe2022 wants to merge 1 commit into
wolfSSL:masterfrom
aidankeefe2022:sni-examples
Draft

aidankeefe2022 wants to merge 1 commit into
wolfSSL:masterfrom
aidankeefe2022:sni-examples

Conversation

@aidankeefe2022

Copy link
Copy Markdown
Member

No description provided.

@aidankeefe2022 aidankeefe2022 self-assigned this Oct 9, 2026
Copilot AI balanced review requested due to automatic review settings October 9, 2026 21:20

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Valid fragmented or case-varied SNI requests can fail, and the documented abort policy contradicts its implementation.

3 open findings
What changed in this PR

Adds TLS 1.3 SNI client/server examples with virtual-host certificate selection and documentation.

Changes:

  • Adds SNI client and multi-host server examples.
  • Documents SNI policies, usage, and certificate validation.
  • Adds integration coverage and ignores generated binaries.
File Description
tls/​server-tls-sni.c Implements SNI-based virtual hosting.
tls/​client-tls-sni.c Implements SNI requests and hostname validation.
tls/​README.md Documents building, policies, and usage.
.github/​examples-manifest.yml Adds an ECC virtual-host integration run.
.gitignore Ignores the new binaries.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread tls/server-tls-sni.c Outdated
Comment thread tls/server-tls-sni.c Outdated
Comment thread tls/README.md Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

ClientHello fragmentation, case-insensitive hostname routing, and abort-policy documentation remain incorrect.

1 open finding
3 resolved since last review

🧠 Review effort: Balanced

Comment thread tls/server-tls-sni.c Outdated

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #644

Scan targets checked: wolfssl-examples-src, wolfssl-examples-bugs
Coverage: 1 of 2 in-scope changed file(s) opened by the reviewer; not opened: tls/client-tls-sni.c

Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Reported findings require changes before merge.

Review tier: Lite

Comment thread tls/server-tls-sni.c Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants