Repository navigation
Quic skeleton example: - #638
Open
aidankeefe2022 wants to merge 2 commits into
Open
aidankeefe2022 wants to merge 2 commits into
aidankeefe2022 wants to merge 2 commits into
Conversation
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #638
Scan targets checked: wolfssl-examples-src, wolfssl-examples-bugs
Coverage: 1 of 3 in-scope changed file(s) opened by the reviewer; not opened: tls/client-quic.c, tls/shared-quic-constants.h
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
aidankeefe2022
force-pushed
the
client-server-quic-example
branch
3 times, most recently
from
October 8, 2026 16:47
8aff4e6 to
13e6ea1
Compare
This was made with the intension of implimenting as little quic details as possible. This means that the wolfSSL functions that are used for quic are front and center and the quic details are intensionally as bear as possible and effectivly a mock implimentation. The comments that precide the different quic steps point out what a real quic implimetaion may do but we are intentional to not be opinoated on the best way to impliment quic and this is not an example of how to impliment a quic server/client but it is an example of how wolfSSL can be used as a tls service for a quic server/client.
aidankeefe2022
force-pushed
the
client-server-quic-example
branch
from
October 8, 2026 17:03
13e6ea1 to
f2931b1
Compare
aidankeefe2022
marked this pull request as ready for review
October 8, 2026 17:33
This was referenced Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was made with the intention of implementing as little Quic details as possible. This means that the wolfSSL functions that are used for Quic are front and center and the Quic details are intentionally as bear as possible and effectively a mock implementation.
The comments that precede the different Quic steps point out what a real Quic implementation may do but we are intentional to not be opinionated on the best way to implement quic and this is not an example of how to implement a Quic server/client but it is an example of how wolfSSL can be used as a TLS service for a Quic server/client.
Structure
The code here is not DRY at all intentionally to put all of the code that is necessary right in front of the reader.
We also have the example as not general at all to improve the the understanding of order and process of each side of the connection for this predetermined handshake and connection.