feat: add buzzer element #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is lovely @gfeun!
What other names can we have for the attribute that controls the music animation? |
|
Also, I'm thinking it'd be cool to have two short wires or leads, possibly red and black, come out of the speaker body. When you search google images for "arduino speaker buzzer", most models that look like this one have red/blue wires coming out of them. This is a bit similar to the LED elements, which also have short leads sticking out of the LED body |
urish
requested changes
Apr 24, 2020
LironHazan
reviewed
Apr 25, 2020
|
I tried to add more details to the buzzer design but the contrast seems to make them undiscernible. |
|
I think it's great the way it is. Do you happen to have a twitter account, btw? |
LironHazan
pushed a commit
to LironHazan/wokwi-elements
that referenced
this pull request
Apr 29, 2020
LironHazan
pushed a commit
to LironHazan/wokwi-elements
that referenced
this pull request
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Uri,
This is my attempt to implement a simple buzzer web component.
I followed your video tutorial to design it with Inkscape.
I wanted the component to display music notes when in use so i implemented a css animation when the attribute "value" is true (similar to the led element on/off). It uses a MIT licensed music note icon
This is very raw since i'm not experienced with css. I am not aware of css animations browser compatibility so this could be a problem too.