ET_interface: set LIB_DIRS, INC_DIRS and LIBS if not specified #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes use of
set_make_varsand ensures instead makes sure that values forREPRIMAND_INC_DIRS,REPRIMAND_LIB_DIRS,REPRIMAND_LIBSare provided if (and only if) they are not yet provided by the user (or build code).set_make_varsdoes unexpected things if, on input,REPRIMAND_LIB_DIRSis not set, and even if it is set it will overwrite the (potentially user specified)REPRIMAND_DIRbased on some assumption on how directories should be organized.This is pull request makes RePrimAnd behave more like (most) other ExternalLibraries and is more respectful of user choices.