Skip to content

Change selector for customInputs in unit tests #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2020
Merged

Change selector for customInputs in unit tests #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 28 additions & 28 deletions src/TimeInput.spec.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ describe('TimeInput', () => {
);

const nativeInput = component.find('input[type="time"]');
const customInputs = component.find('input[type="number"]');
const customInputs = component.find('input[data-input]');

expect(nativeInput).toHaveLength(1);
expect(customInputs).toHaveLength(2);
Expand All @@ -73,7 +73,7 @@ describe('TimeInput', () => {
/>
);

const customInputs = component.find('input[type="number"]');
const customInputs = component.find('input[data-input]');
const secondInput = customInputs.find('input[name="second"]');
const minuteInput = customInputs.find('input[name="minute"]');
const hourInput = customInputs.find('input[name^="hour"]');
Expand All @@ -92,7 +92,7 @@ describe('TimeInput', () => {
/>
);

const customInputs = component.find('input[type="number"]');
const customInputs = component.find('input[data-input]');
const secondInput = customInputs.find('input[name="second"]');
const minuteInput = customInputs.find('input[name="minute"]');
const hourInput = customInputs.find('input[name^="hour"]');
Expand All @@ -115,7 +115,7 @@ describe('TimeInput', () => {
);

const nativeInput = component.find('input[type="time"]');
const customInputs = component.find('input[type="number"]');
const customInputs = component.find('input[data-input]');

expect(nativeInput.prop('value')).toBe(date);
expect(customInputs.at(0).prop('value')).toBe(10);
Expand All @@ -136,7 +136,7 @@ describe('TimeInput', () => {
);

const nativeInput = component.find('input[type="time"]');
const customInputs = component.find('input[type="number"]');
const customInputs = component.find('input[data-input]');

expect(nativeInput.prop('value')).toBe(date);
expect(customInputs.at(0).prop('value')).toBe(22);
Expand All @@ -154,7 +154,7 @@ describe('TimeInput', () => {
);

const nativeInput = component.find('input[type="time"]');
const customInputs = component.find('input[type="number"]');
const customInputs = component.find('input[data-input]');

expect(nativeInput.prop('value')).toBeFalsy();
expect(customInputs.at(0).prop('value')).toBeFalsy();
Expand All @@ -176,7 +176,7 @@ describe('TimeInput', () => {
component.setProps({ value: null });

const nativeInput = component.find('input[type="time"]');
const customInputs = component.find('input[type="number"]');
const customInputs = component.find('input[data-input]');

expect(nativeInput.prop('value')).toBeFalsy();
expect(customInputs.at(0).prop('value')).toBeFalsy();
Expand All @@ -192,7 +192,7 @@ describe('TimeInput', () => {
/>
);

const customInputs = component.find('input[type="number"]');
const customInputs = component.find('input[data-input]');

expect(customInputs.at(0).prop('name')).toBe('hour12');
expect(customInputs.at(1).prop('name')).toBe('minute');
Expand All @@ -208,7 +208,7 @@ describe('TimeInput', () => {
/>
);

const customInputs = component.find('input[type="number"]');
const customInputs = component.find('input[data-input]');

expect(customInputs.at(0).prop('name')).toBe('hour24');
expect(customInputs.at(1).prop('name')).toBe('minute');
Expand Down Expand Up @@ -264,7 +264,7 @@ describe('TimeInput', () => {
);

const componentInput = component.find('Hour12Input');
const customInputs = component.find('input[type="number"]');
const customInputs = component.find('input[data-input]');

expect(componentInput).toHaveLength(1);
expect(customInputs).toHaveLength(1);
Expand All @@ -279,7 +279,7 @@ describe('TimeInput', () => {
);

const componentInput = component.find('Hour12Input');
const customInputs = component.find('input[type="number"]');
const customInputs = component.find('input[data-input]');

expect(componentInput).toHaveLength(1);
expect(customInputs).toHaveLength(1);
Expand Down Expand Up @@ -310,7 +310,7 @@ describe('TimeInput', () => {
);

const componentInput = component.find('Hour24Input');
const customInputs = component.find('input[type="number"]');
const customInputs = component.find('input[data-input]');

expect(componentInput).toHaveLength(1);
expect(customInputs).toHaveLength(1);
Expand All @@ -325,7 +325,7 @@ describe('TimeInput', () => {
);

const componentInput = component.find('Hour24Input');
const customInputs = component.find('input[type="number"]');
const customInputs = component.find('input[data-input]');

expect(componentInput).toHaveLength(1);
expect(customInputs).toHaveLength(1);
Expand Down Expand Up @@ -356,7 +356,7 @@ describe('TimeInput', () => {
);

const componentInput = component.find('MinuteInput');
const customInputs = component.find('input[type="number"]');
const customInputs = component.find('input[data-input]');

expect(componentInput).toHaveLength(1);
expect(customInputs).toHaveLength(1);
Expand All @@ -371,7 +371,7 @@ describe('TimeInput', () => {
);

const componentInput = component.find('MinuteInput');
const customInputs = component.find('input[type="number"]');
const customInputs = component.find('input[data-input]');

expect(componentInput).toHaveLength(1);
expect(customInputs).toHaveLength(1);
Expand Down Expand Up @@ -402,7 +402,7 @@ describe('TimeInput', () => {
);

const componentInput = component.find('SecondInput');
const customInputs = component.find('input[type="number"]');
const customInputs = component.find('input[data-input]');

expect(componentInput).toHaveLength(1);
expect(customInputs).toHaveLength(1);
Expand All @@ -417,7 +417,7 @@ describe('TimeInput', () => {
);

const componentInput = component.find('SecondInput');
const customInputs = component.find('input[type="number"]');
const customInputs = component.find('input[data-input]');

expect(componentInput).toHaveLength(1);
expect(customInputs).toHaveLength(1);
Expand Down Expand Up @@ -448,7 +448,7 @@ describe('TimeInput', () => {
);

const componentInput = component.find('AmPm');
const customInputs = component.find('input[type="number"]');
const customInputs = component.find('input[data-input]');

expect(componentInput).toHaveLength(1);
expect(customInputs).toHaveLength(0);
Expand Down Expand Up @@ -477,7 +477,7 @@ describe('TimeInput', () => {
);

const separators = component.find('.react-time-picker__inputGroup__divider');
const customInputs = component.find('input[type="number"]');
const customInputs = component.find('input[data-input]');
const ampm = component.find('select');

expect(separators).toHaveLength(customInputs.length + ampm.length - 1);
Expand All @@ -492,7 +492,7 @@ describe('TimeInput', () => {
{ attachTo: container }
);

const customInputs = component.find('input[type="number"]');
const customInputs = component.find('input[data-input]');
const hourInput = customInputs.at(0);
const minuteInput = customInputs.at(1);

Expand All @@ -514,7 +514,7 @@ describe('TimeInput', () => {
{ attachTo: container }
);

const customInputs = component.find('input[type="number"]');
const customInputs = component.find('input[data-input]');
const hourInput = customInputs.at(0);
const minuteInput = customInputs.at(1);

Expand Down Expand Up @@ -558,7 +558,7 @@ describe('TimeInput', () => {
{ attachTo: container }
);

const customInputs = component.find('input[type="number"]');
const customInputs = component.find('input[data-input]');
const hourInput = customInputs.at(0);
const minuteInput = customInputs.at(1);

Expand All @@ -580,7 +580,7 @@ describe('TimeInput', () => {
{ attachTo: container }
);

const customInputs = component.find('input[type="number"]');
const customInputs = component.find('input[data-input]');
const hourInput = customInputs.at(0);

hourInput.getDOMNode().focus();
Expand All @@ -598,7 +598,7 @@ describe('TimeInput', () => {
{ attachTo: container }
);

const customInputs = component.find('input[type="number"]');
const customInputs = component.find('input[data-input]');
const hourInput = customInputs.at(0);
const minuteInput = customInputs.at(1);

Expand All @@ -616,7 +616,7 @@ describe('TimeInput', () => {
{ attachTo: container }
);

const customInputs = component.find('input[type="number"]');
const customInputs = component.find('input[data-input]');
const hourInput = customInputs.at(0);
const minuteInput = customInputs.at(1);

Expand All @@ -634,7 +634,7 @@ describe('TimeInput', () => {
{ attachTo: container }
);

const customInputs = component.find('input[type="number"]');
const customInputs = component.find('input[data-input]');
const hourInput = customInputs.at(0);

hourInput.getDOMNode().focus();
Expand All @@ -658,7 +658,7 @@ describe('TimeInput', () => {
/>
);

const customInputs = component.find('input[type="number"]');
const customInputs = component.find('input[data-input]');

customInputs.at(0).getDOMNode().value = '20';
customInputs.at(0).simulate('change');
Expand All @@ -680,7 +680,7 @@ describe('TimeInput', () => {
/>
);

const customInputs = component.find('input[type="number"]');
const customInputs = component.find('input[data-input]');

customInputs.forEach((customInput) => {
customInput.getDOMNode().value = ''; // eslint-disable-line no-param-reassign
Expand Down
1 change: 1 addition & 0 deletions src/TimeInput/Input.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ export default function Input({
`${className}__${nameForClass || name}`,
hasLeadingZero && `${className}__input--hasLeadingZero`,
)}
data-input="true"
disabled={disabled}
max={max}
min={min}
Expand Down
2 changes: 1 addition & 1 deletion src/TimePicker.spec.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,7 @@ describe('TimePicker', () => {
<TimePicker isOpen />
);

const customInputs = component.find('input[type="number"]');
const customInputs = component.find('input[data-input]');
const hourInput = customInputs.at(0);
const minuteInput = customInputs.at(1);

Expand Down