Fix customTextRenderer not called on items outside of marked content (#…

…1623) Closes #1593
wojtekmaj · Oct 5, 2023 · b862a52 · b862a52
1 parent 178317f
commit b862a52
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/packages/react-pdf/src/Page/TextLayer.spec.tsx b/packages/react-pdf/src/Page/TextLayer.spec.tsx
@@ -38,7 +38,7 @@ function renderWithContext(children: React.ReactNode, context: Partial<PageConte
 function getTextItems(container: HTMLElement) {
   const wrapper = container.firstElementChild as HTMLDivElement;
 
-  return wrapper.querySelectorAll('.markedContent > *:not(.markedContent');
+  return wrapper.querySelectorAll('[role="presentation"]');
 }
 
 describe('TextLayer', () => {

diff --git a/packages/react-pdf/src/Page/TextLayer.tsx b/packages/react-pdf/src/Page/TextLayer.tsx
@@ -204,11 +204,7 @@ export default function TextLayer() {
         layer.append(end);
         endElement.current = end;
 
-        const hasMarkedContent = Boolean(layer.querySelector('.markedContent'));
-
-        const layerChildren = hasMarkedContent
-          ? layer.querySelectorAll('.markedContent > *:not(.markedContent')
-          : layer.children;
+        const layerChildren = layer.querySelectorAll('[role="presentation"]');
 
         if (customTextRenderer) {
           let index = 0;