Fix typo in component name #888
Conversation
src/shared/propTypes.ts
Outdated
| export const isViews = PropTypes.arrayOf(PropTypes.oneOf(allViews)); | ||
|
|
||
| export const isView: Requireable<View> = function isView(props, propName, componentName) { | ||
| export const isView: Requireable<View> = function (props, propName, componentName) { |
There was a problem hiding this comment.
We don't think you need a function name for that code.
There was a problem hiding this comment.
This makes sure we're getting the right error stack of something throws an error.
There was a problem hiding this comment.
I missed it, thanks
| minDate?: Date; | ||
| setMaxDate: (date?: Date) => void; | ||
| setMinDate: (date?: Date) => void; | ||
| }; |
There was a problem hiding this comment.
I think it would be cleaner to use Optional Property.
There was a problem hiding this comment.
There's a significant difference between "this property must be passed, but may be undefined somewhere down the line" and "you can forget about passing that property and it will be alright". It's purposeful.
There was a problem hiding this comment.
@wojtekmaj Wow, that's right, I get it.
|
Hi! Most of your changes, removing React.FC are causing duplicated types to be produced, resulting in errors in some IDEs. This has been fixed in 70bd390 and I have no plans of rolling it back unless a better solution is proposed. The typo is legit though. :D |
|
@wojtekmaj |
|
@wojtekmaj |
wojtekmaj
changed the title
|
Thanks! 👍 |
|
@wojtekmaj |
Hello 👋, @wojtekmaj
Thanks for sharing this great library.
I fixed a typo in the component name.