Skip to content

Fix crash on IE 11 caused by passing date to Date constructor #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2021
Merged

Fix crash on IE 11 caused by passing date to Date constructor #480

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/Calendar.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,14 @@ const baseClassName = 'react-calendar';
const allViews = ['century', 'decade', 'year', 'month'];
const allValueTypes = [...allViews.slice(1), 'day'];

function toDate(value) {
if (value instanceof Date) {
return value;
}

return new Date(value);
}

/**
* Returns views array with disallowed values cut off.
*/
Expand Down Expand Up @@ -71,7 +79,7 @@ function getValue(value, index) {
return null;
}

const valueDate = new Date(rawValue);
const valueDate = toDate(rawValue);

if (isNaN(valueDate.getTime())) {
throw new Error(`Invalid date: ${value}`);
Expand Down