Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add formatWeekday prop #620

Closed
1 task done
swissspidy opened this issue Jun 20, 2022 · 3 comments
Closed
1 task done

Add formatWeekday prop #620

swissspidy opened this issue Jun 20, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@swissspidy
Copy link

Before you start - checklist

  • I have checked if this feature request is not already reported

Description

formatDay, formatMonth, etc. can all be customized via props — except for formatWeekday, which is used in MonthView/Weekdays here:

const abbr = formatWeekday(locale, weekdayDate);
weekdays.push(
<div
key={weekday}
className={mergeClassNames(
weekdayClassName,
isWeekend(weekdayDate, calendarType) && `${weekdayClassName}--weekend`,
)}
>
<abbr aria-label={abbr} title={abbr}>
{formatShortWeekday(locale, weekdayDate).replace('.', '')}
</abbr>
</div>,
);

Proposed solution

Add a formatWeekday prop to allow passing a custom formatter

Alternatives

No response

Additional information

No response

@github-actions
Copy link
Contributor

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this issue will be closed in 14 days.

@github-actions github-actions bot added the stale label Sep 19, 2022
@swissspidy
Copy link
Author

This is still relevant

@wojtekmaj
Copy link
Owner

Thanks for the bump, @swissspidy (and @github-actions 😂)! This will be released in the next React-Calendar version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants