-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extension and reimplementation of Shirley background substraction #36
Open
MarcBHahn
wants to merge
12
commits into
wojdyr:master
Choose a base branch
from
MarcBHahn:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…selection of an active region.
Improves Shirley BG substraction by calculation of ymin and ymax parameter from the average of up to five surrounding datapoints. This improves the Shirley BG estimation for XPS data with bad signal to noise ratio.
Hi Marc, |
Improved ShirleyBG substraction
wojdyr
reviewed
Sep 19, 2021
Correct comments.
Adjust indices of Shirley background removal procedure for the analysis of XPS spectra.
Add the changes from main branch to prepare a new version fpr the pull request
Improve initial guess for shirleyBG determination to improve the starting values for the iterative procedure.
Add installation information about autogen.sh
merge updates from main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
I reimplemented the section to substract a Shirley background as used in XPS.
It is now possible to substract a Shirley background only within the active region as it is often done in XPS. Additionally the implementation seems to be more stable when working with data having a bad SNR.
Best wishes
Marc