Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Drupal 10.1 CSS/JS aggregation. #84

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Add support for Drupal 10.1 CSS/JS aggregation. #84

merged 1 commit into from
Jun 20, 2023

Conversation

Niklan
Copy link
Contributor

@Niklan Niklan commented Jun 15, 2023

https://www.drupal.org/node/2888767:

Sites using nginx/php-fpm may need to update their nginx.conf file to pass through the css/js path to Drupal.

Before

# Passes style generation to PHP.
location ~ ^/sites/.*/files/styles/ {
  try_files $uri @rewrite;
}

After

# Passes image style and asset generation to PHP.
location ~ ^/sites/.*/files/(css|js|styles)/ {
  try_files $uri @rewrite;
}

Basically, without this rewrite for CSS and JS the files most likely won't be generated after Drupal 10.1 update.

@dclause
Copy link

dclause commented Jun 18, 2023

+1 for this change here :)

@csandanov csandanov merged commit abf638a into wodby:master Jun 20, 2023
@Niklan Niklan deleted the Niklan-patch-1 branch June 20, 2023 14:33
@csandanov
Copy link
Member

Thanks!

@apermuy
Copy link

apermuy commented Dec 24, 2023

Thanks! Works fine with Drupal 10.2 and Nginx 1.18.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants