Add QQuickWindow and QQuickItem::window_changed #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some types that I will need to later on bind types related to QSGRendererInterface. Not related to this pull request, did we want to split `qtdeclarative.rs` up. I suspect that the file will definitely grow quite a bit.
i509VCB
commented
Nov 15, 2023
Comment on lines
+794
to
+796
| pub unsafe fn from_raw<'a>(ptr: *mut c_void) -> &'a Self { | ||
| std::mem::transmute(ptr) | ||
| } |
There was a problem hiding this comment.
Now that I realize it, this is undefined behavior...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some types that I will need to later on bind types related to QSGRendererInterface.
Not related to this pull request, did we want to split
qtdeclarative.rsup? I suspect that the file will definitely grow quite a bit.