Skip to content

Commit

Permalink
Put the QPrivateSignal argument in the args array
Browse files Browse the repository at this point in the history
Fix for QTBUG-59414
  • Loading branch information
ogoffart committed Mar 13, 2017
1 parent 87084cf commit d74de78
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions src/generator.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1146,8 +1146,7 @@ void Generator::GenerateSignal(const clang::CXXMethodDecl *MD, int Idx)
for (uint j = 0 ; j < MD->getNumParams(); ++j) {
if (j) OS_TemplateHeader << ",";
OS_TemplateHeader << MD->getParamDecl(j)->getType().getAsString(PrintPolicy);
if (!(j == MD->getNumParams() - 1 && HasPrivateSignal(MD)))
OS_TemplateHeader << " _t" << (j+1);;
OS_TemplateHeader << " _t" << (j+1);;
}
OS_TemplateHeader << ")";
std::string This = "this";
Expand All @@ -1160,7 +1159,6 @@ void Generator::GenerateSignal(const clang::CXXMethodDecl *MD, int Idx)
OS_TemplateHeader << "\n{\n";
bool IsVoid = ReturnType->isVoidType();
unsigned int NumParam = MD->getNumParams();
if (HasPrivateSignal(MD)) NumParam--;
if (IsVoid && NumParam == 0) {
OS_TemplateHeader << " QMetaObject::activate(" << This << ", &staticMetaObject, " << Idx << ", 0);\n";
} else {
Expand Down

0 comments on commit d74de78

Please sign in to comment.