Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set local session posargs via notify #397
set local session posargs via notify #397
Changes from all commits
b79cdd8
ed41e13
dc115dd
06a01ec
db4ed2f
4a66fe0
a54a859
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we inoculate
global_config.posargs
against mutation here?Now that every session conceptually has their own
posargs
, I think it makes sense to prevent one session from accidentally mutating the defaultposargs
of other sessions.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh dear, this breaks a whole lot of tests 😅
Essentially, there are three groups of tests that break:
is
instead of==
Here's a patch that would make this green again.
(Some of these could be turned into fixtures.)
I think we can also choose to be pragmatic here, and keep this as it is. After all, the mutability of
session.posargs
is undocumented and an implementation detail, and should not be used in Noxfiles. What do you think?@theacodes What's your take on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we're thinking about making breaking change we should also consider turning
posargs
into a tuple. Havingposargs
be a list just seems like you're offering people enough rope to hang themselves with.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that a tuple would be preferable. (Changing the type might not even constitute a breaking change; the exact type is not documented and most Noxfiles probably just unpack into
session.run
.) But I think we can merge this without addressing the issue here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll create an issue to capture this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See here: #400