Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing PathLike types to Session.chdir() #376

Merged
merged 1 commit into from
Jan 22, 2021
Merged

Allow passing PathLike types to Session.chdir() #376

merged 1 commit into from
Jan 22, 2021

Conversation

jdufresne
Copy link
Contributor

os.chdir() has supported PathLib since Python 3.6.

Discovered while adding types pip's noxfile.py:
pypa/pip#9411

@jdufresne
Allow passing PathLike types to Session.chdir()
aaf4b2e 
os.chdir() has supported PathLib since Python 3.6.

Discovered while adding types pip's noxfile.py:
pypa/pip#9411
@jdufresne jdufresne mentioned this pull request Jan 1, 2021
Merged
stsewd
stsewd approved these changes Jan 22, 2021
View reviewed changes
Copy link
Collaborator

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stsewd stsewd merged commit 156765c into wntrblm:master Jan 22, 2021
@jdufresne jdufresne deleted the pathlib branch January 22, 2021 19:00
@cjolowicz cjolowicz mentioned this pull request Jun 6, 2021
Merged
@mlech-reef mlech-reef mentioned this pull request Oct 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stsewd stsewd stsewd approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdufresne @stsewd