Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor pip as python -m pip #363

Merged
merged 3 commits into from
Dec 28, 2020
Merged

Refactor pip as python -m pip #363

merged 3 commits into from
Dec 28, 2020

Conversation

V1NAY8
Copy link
Contributor

@V1NAY8 V1NAY8 commented Nov 23, 2020

Closes #262

  • Refactored pip as python -m pip. Since It is a good practice.

@theacodes Please review 😃

stsewd
stsewd approved these changes Nov 25, 2020
View reviewed changes
Copy link
Collaborator

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM! Just one question, wouldn't this affect Windows users? I think python is just py some times in Windows, I don't use Windows, so I can't test this.

@V1NAY8
Copy link
Contributor Author

V1NAY8 commented Nov 26, 2020

I tested my changes in windows itself (In virtualenv and globally too). I didn't face any issue.

@stsewd
Copy link
Collaborator

stsewd commented Dec 1, 2020

Looks like this is needed for windows #262 (comment) anyway :)

Merging after CI passes

@V1NAY8
Copy link
Contributor Author

V1NAY8 commented Dec 2, 2020

CI's good 💯

@stsewd stsewd merged commit cdb391f into wntrblm:master Dec 28, 2020
@V1NAY8 V1NAY8 deleted the refactor-pip branch December 29, 2020 14:29
@dependabot dependabot bot mentioned this pull request Mar 16, 2021
Merged
@mlech-reef mlech-reef mentioned this pull request Oct 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stsewd stsewd stsewd approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use 'python -m pip' instead of 'pip' for package installs.
2 participants
@V1NAY8 @stsewd