Skip to content

Commit

Permalink
Fix assertion in GHA tests (#670)
Browse files Browse the repository at this point in the history
* Fix assertion in GHA tests

* Remove ubuntu 18.04 from actions default tests as it's deprecated
  • Loading branch information
FollowTheProcess authored Nov 24, 2022
1 parent 53c8d7c commit cc710bd
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 8 deletions.
20 changes: 14 additions & 6 deletions .github/workflows/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,29 @@ name: Action
on:
push:
branches:
- 'main'
- '**action**'
- "main"
- "**action**"
pull_request:
paths:
- '.github/workflows/action.yml'
- '.github/action_helper.py'
- 'action.yml'
- ".github/workflows/action.yml"
- ".github/action_helper.py"
- "action.yml"
env:
FORCE_COLOR: "1"
jobs:
action-default-tests:
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ubuntu-18.04, ubuntu-20.04, ubuntu-22.04, windows-2019, windows-2022, macos-11, macos-12]
os:
[
ubuntu-20.04,
ubuntu-22.04,
windows-2019,
windows-2022,
macos-11,
macos-12,
]
steps:
- uses: actions/checkout@v3
- uses: ./
Expand Down
6 changes: 4 additions & 2 deletions noxfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -130,10 +130,12 @@ def _check_python_version(session: nox.Session) -> None:
)


@nox.session(python=["3.7", "3.8", "3.9", "3.10", "pypy3.7", "pypy3.8", "pypy3.9"])
@nox.session(
python=["3.7", "3.8", "3.9", "3.10", "3.11", "pypy3.7", "pypy3.8", "pypy3.9"]
)
def github_actions_default_tests(session: nox.Session) -> None:
"""Check default versions installed by the nox GHA Action"""
assert sys.version_info[:2] == (3, 10)
assert sys.version_info[:2] == (3, 11)
_check_python_version(session)


Expand Down

0 comments on commit cc710bd

Please sign in to comment.