Skip to content

Conversation

@hauserkristof
Copy link
Contributor

Small things:

  • added biome to lint & format js code
  • added biome and zig extenstion recommendation to vscode
  • fix some lint issues

New features:

  • improved error handling
  • skip layer generation is the layer is empty (this caused issues in local development)
  • add option (default true), to mirror back layers on exported PCB

@theacodes
Copy link
Collaborator

Hi! Thank you for doing this, I really do appreciate it. There's a lot of changes in this PR, and it would be easier to review if it were broken up into separate PRs - ideally one for each of those bullet points. I understand if that's more than you'd like to volunteer to do, and if that's the case I'll handle doing it myself once I have some more time.

Also, more specifically I don't think the mirror option should default to true, since that changes existing behavior and all existing designs for use with Gingerbread would break.

@hauserkristof
Copy link
Contributor Author

Hey!

Of course, I can break it up into smaller pieces :)

I will do it tomorrow. I also have a separate PR, that adds the ability to preview different copper finish colors.

It crossed my mind that, for fun, I could migrate the project to TypeScript and develop a better development experience.

What are your thoughts on this?

@hauserkristof
Copy link
Contributor Author

Also, if you have other linter / formatter preferences, like Prettier, I could use that instead of Biome.

@theacodes
Copy link
Collaborator

theacodes commented Dec 8, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants