Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm OTP Token #72

Merged
merged 28 commits into from
May 20, 2024
Merged

Confirm OTP Token #72

Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
a83a5dd
scaffold solution for confirming OTP before enabling OTP;
strouptl May 13, 2024
e3b929d
Add instructions to confirm_otp_token form;
strouptl May 13, 2024
f960474
move "Enable Authentication" form to separate "edit" view; reduce "sh…
strouptl May 13, 2024
01a402f
use existing edit/update actions on otp_tokens controller for confirm…
strouptl May 13, 2024
cc9067e
remove token explanation from show page;
strouptl May 15, 2024
fed4602
update flash message for failed confirmation;
strouptl May 15, 2024
fab7c1c
move locales for OTP confirmation form to edit_otp_tokens scope; dele…
strouptl May 15, 2024
7920bd3
differentiate title of show and edit pages; move "title" value for ed…
strouptl May 15, 2024
5ba39da
revert method name to enable_top!;
strouptl May 17, 2024
7074c2f
revert "h2" for otp_tokens#show to locale file;
strouptl May 17, 2024
2b3f893
use enable_link config locale in otp_tokens#show;
strouptl May 17, 2024
ffdf493
use locales for otp_token field and submit button; switch terminology…
strouptl May 17, 2024
ebd03ca
match terminology to AWS MFA form;
strouptl May 17, 2024
debe1c1
replace remaining reference to "Verification Code";
strouptl May 17, 2024
f30aa59
add tests for enabling two-factor authentication via dedicated otp_to…
strouptl May 18, 2024
0a9dc5a
update test helpers and initial sign_in test for new Enable Two-Facto…
strouptl May 18, 2024
8bc2b83
update otp_tokens#update to redirect to show action as before (rather…
strouptl May 18, 2024
074b67e
update disable test to confirm correct status displayed; remove accep…
strouptl May 18, 2024
1e94af0
update EnableOtpForm tests to reload user before checking whether OTP…
strouptl May 18, 2024
61f46a2
add populate_otp! method for populating initial secrets; add instruct…
strouptl May 19, 2024
e9215f4
update otp_tokens controller to populate otp secrets as needed; renam…
strouptl May 19, 2024
747cefa
update button text and warnings for disabling 2FA; remove instruction…
strouptl May 19, 2024
3293345
update tests for change; add otp_failed_attempts to destroy_otp_secre…
strouptl May 19, 2024
dfe9d45
rename destroy_otp_secrets! to clear_otp_fields! for consistency (sin…
strouptl May 19, 2024
0ca939f
simplify populate_otp_secrets! method;
strouptl May 19, 2024
51dca03
draft CHANGELOG insertion for requiring confirmation token and popula…
strouptl May 20, 2024
04fa4a7
rename "otp_token" input to "confirmation_code"; make edit_otp_token …
strouptl May 20, 2024
8cbc133
Update CHANGELOG.md to fix list indentation issue;
May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
revert "h2" for otp_tokens#show to locale file;
  • Loading branch information
@strouptl
strouptl committed May 18, 2024
commit 7074c2fa834ceecbb36bc3e58eb7dd261f969253
2 changes: 1 addition & 1 deletion app/views/devise/otp_tokens/show.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<h2>Two-Factor-Authentication</h2>
<h2><%= I18n.t('title', :scope => 'devise.otp.otp_tokens') %></h2>

<p><strong>Status:</strong> <%= resource.otp_enabled? ? "Enabled" : "Disabled" %></p>

Expand Down