Skip to content

Commit

Permalink
Update Two-Factor Authentication spelling (#84)
Browse files Browse the repository at this point in the history
* make spelling of Two-Factor Authentication consistent;

* add CHANGELOG entry;
  • Loading branch information
strouptl authored Jun 9, 2024
1 parent fb78aa6 commit ec48a1d
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 15 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## UNRELEASED

Update spelling and capitalization of Two-Factor Authentication for consistency;

## UNRELEASED

Utilize native Warden redirect for redirecting to OTP credentials form.

Changes:
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Devise::OTP

Devise OTP is a two-factors authentication extension for Devise. The second factor is done using an [RFC 6238](https://datatracker.ietf.org/doc/html/rfc6238) Time-Based One-Time Password (TOTP) implemented by the [rotp library](https://github.com/mdp/rotp).
Devise OTP is a Two-Factor Authentication extension for Devise. The second factor is done using an [RFC 6238](https://datatracker.ietf.org/doc/html/rfc6238) Time-Based One-Time Password (TOTP) implemented by the [rotp library](https://github.com/mdp/rotp).

It has the following features:

Expand All @@ -19,7 +19,7 @@ Device OTP was recently updated to work with Rails 7 and Turbo.

Devise::OTP development is sponsored by [Business Class](https://businessclasskit.com/) Rails SaaS starter kit. If you don't want to setup OTP yourself for your new project, consider starting one on Business Class.

## Two-factors authentication using OTP
## Two-Factor Authentication using OTP

* A shared secret is generated on the server, and stored both on the token device (e.g. the phone) and the server itself.
* The secret is used to generate short numerical tokens that are either time or sequence based.
Expand Down
22 changes: 11 additions & 11 deletions config/locales/en.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ en:
remember: Remember me
submit_token:
title: 'Check Token'
explain: "You're getting this because you enabled two-factors authentication on your account"
prompt: 'Please enter your two-factors authentication token:'
explain: "You're getting this because you enabled Two-Factor Authentication on your account"
prompt: 'Please enter your Two-Factor Authentication token:'
recovery_prompt: 'Please enter your recovery code:'
submit: 'Submit Token'
recovery_link: "I don't have my device, I want to use a recovery code"
Expand All @@ -21,21 +21,21 @@ en:
explain: 'In order to ensure this is safe, please enter your password again.'
go_on: 'Continue...'
identity: 'Identity:'
token: 'Your two-factors authentication token'
token: 'Your Two-Factor Authentication token'
token_secret:
title: 'Your token secret'
explain: 'Take a photo of this QR code with your mobile'
manual_provisioning: 'Manual provisioning code'
otp_tokens:
title: 'Two-factors Authentication:'
title: 'Two-Factor Authentication:'
enable_link: 'Enable Two-Factor Authentication'
disable_link: 'Disable Two-Factor Authentication'
reset_link: 'Reset Token Secret'
reset_explain: 'Resetting your token secret will temporarilly disable Two-Factor authentication.'
reset_explain_warn: 'To re-enable Two-Factor authentication, you will need to re-enroll your mobile device with the new token secret.'
successfully_updated: 'Your two-factors authentication settings have been updated.'
reset_explain: 'Resetting your token secret will temporarilly disable Two-Factor Authentication.'
reset_explain_warn: 'To re-enable Two-Factor Authentication, you will need to re-enroll your mobile device with the new token secret.'
successfully_updated: 'Your Two-Factor Authentication settings have been updated.'
could_not_confirm: 'The Confirmation Code you entered did not match the QR code shown below.'
successfully_disabled_otp: 'Two-Factor authentication has been disabled.'
successfully_disabled_otp: 'Two-Factor Authentication has been disabled.'
successfully_reset_otp: 'Your token secret has been reset. Please confirm your new token secret below.'
successfully_set_persistence: 'Your device is now trusted.'
successfully_cleared_persistence: 'Your device has been removed from the list of trusted devices.'
Expand All @@ -49,16 +49,16 @@ en:
codes_list: 'Here is the list of your recovery codes'
download_codes: 'Download recovery codes'
edit_otp_token:
title: 'Enable Two-factors Authentication'
explain: 'Two factors authentication adds an additional layer of security to your account. When logging in you will be asked for a code that you can generate on a physical device, like your phone.'
title: 'Enable Two-factor Authentication'
explain: 'Two-Factor Authentication adds an additional layer of security to your account. When logging in you will be asked for a code that you can generate on a physical device, like your phone.'
lead_in: 'To Enable Two-Factor Authentication:'
step_1: '1. Open your authenticator app and scan the QR code shown below:'
step_2: '2. Enter the 6-digit code shown in your authenticator app below:'
confirmation_code: "Confirmation Code"
submit: 'Continue...'
trusted_browsers:
title: 'Trusted Browsers'
explain: 'If you set your browser as trusted, you will not be asked to provide a Two-factor authentication token when logging in from that browser.'
explain: 'If you set your browser as trusted, you will not be asked to provide a Two-Factor Authentication token when logging in from that browser.'
browser_trusted: 'Your browser is trusted.'
browser_not_trusted: 'Your browser is not trusted.'
trust_remove: 'Remove this browser from the list of trusted browsers'
Expand Down
4 changes: 2 additions & 2 deletions test/integration/sign_in_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,15 @@ def teardown
assert_equal posts_path, current_path
end

test "a new user, just signed in, should be able to see and click the 'Enable Two Factor Authentication' link" do
test "a new user, just signed in, should be able to see and click the 'Enable Two-Factor Authentication' link" do
user = sign_user_in

visit user_otp_token_path
assert page.has_content?("Disabled")

click_link "Enable Two-Factor Authentication"

assert page.has_content?("Enable Two-factors Authentication")
assert page.has_content?("Enable Two-Factor Authentication")
assert_equal edit_user_otp_token_path, current_path
end

Expand Down

0 comments on commit ec48a1d

Please sign in to comment.