Fixes microsoft#34913: Wait for * activation when the command is no…

…t registered
wminos · Feb 7, 2018 · 4c43954 · 4c43954
1 parent 370e10e
commit 4c43954
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/src/vs/platform/commands/common/commandService.ts b/src/vs/platform/commands/common/commandService.ts
@@ -38,11 +38,16 @@ export class CommandService extends Disposable implements ICommandService {
 		// host didn't yet start and the command is already registered
 
 		const activation = this._extensionService.activateByEvent(`onCommand:${id}`);
+		const commandIsRegistered = !!CommandsRegistry.getCommand(id);
 
-		if (!this._extensionHostIsReady && CommandsRegistry.getCommand(id)) {
+		if (!this._extensionHostIsReady && commandIsRegistered) {
 			return this._tryExecuteCommand(id, args);
 		} else {
-			return activation.then(_ => this._tryExecuteCommand(id, args));
+			let waitFor: TPromise<any> = activation;
+			if (!commandIsRegistered) {
+				waitFor = TPromise.join([activation, this._extensionService.activateByEvent(`*`)]);
+			}
+			return waitFor.then(_ => this._tryExecuteCommand(id, args));
 		}
 	}