Conversation
|
I don't get it. The error is here as well!? Also, about that npm warning - where the heck is the |
Doesn’t that also need to be changed in |
Mh, good point. But it didn't complain for LookupInput.vue 🤔. The only difference that I notice as first glance would be how the |
|
This is very strange, everything seems to be green locally (so, the package/lock errors aren’t there, but also, eslint isn’t complaining about |
Maybe this will help in figuring out problems that show up only in CI and not locally.
Since version 0.18.0 the wikimedia/node package includes linting for .json files. So we use that instead of using our own. Also, this now fixes some inconsistent spacing in some json files. Further, this installs eslint-plugin-jsdoc as a dependency, because otherwise eslint complains, even though we do not use it directly.
The wikimedia/client config pulls in client-es5, so if we actually want es6 linting, then we should use wikimedia/client-es6. That also complains about some shadowed variables, which are fixed in this commit as well. This adds eslint-plugin-es as a dev dependency, because somehow eslint does not manage to find it as a dependency of eslint-config-wikimedia.
It is unclear how or why the package-lock files became out of sync, but adding --ci to the lerna bootstrap command allowed to reproduce and subsequently fix the issue.
This fixed all component test suites failing with an error similar to:
FAIL tests/unit/components/Lookup.spec.ts
● Test suite failed to run
No element indexed by 27
at ArraySet_at [as at] (node_modules/@vue/vue3-jest/node_modules/source-map/lib/array-set.js:92:9)
at Array.map (<anonymous>)
at mapLines (node_modules/@vue/vue3-jest/lib/map-lines.js:12:18)
at processScript (node_modules/@vue/vue3-jest/lib/process.js:47:16)
at Object.module.exports [as process] (node_modules/@vue/vue3-jest/lib/process.js:162:24)
|
(This still works for me locally with node 14) |
lucaswerkmeister
left a comment
lucaswerkmeister
left a comment
There was a problem hiding this comment.
LGTM apart from some leftover debug output (I assume); also works for me in Fresh
Co-authored-by: Lucas Werkmeister <lucas.werkmeister@wikimedia.de>
micgro42
changed the title
2 participants
The
TextInputcomponent was adjusted to satisfy the error message: