Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script for caching images #49

Closed
wants to merge 2 commits into from
Closed

Add script for caching images #49

wants to merge 2 commits into from

Conversation

toban
Copy link
Contributor

@toban toban commented Oct 16, 2021

The minikube cache all command does not seem to work for me, this seems to
work though.

The minikube cache all command does not seem to work for me, this seems
to work though. But haven't confirmed that wiping the cluster would
re-use this cache.
@tarrow
Copy link
Contributor

tarrow commented Oct 18, 2021

Takes my time down from timing out to 1:41.93 when running helmfile apply to my local minikube cluster.

Of course unfortunately it spits out cache minikube deprecation warnings. I'm also slightly worried after reading the docs we might get caught by some bugs in pulling new images (particularly after we starting using mutable rather than unique tags) see: kubernetes/minikube#10060

I'm torn but I suspect we don't actually want to merge this for this reason.

@toban
Copy link
Contributor Author

toban commented Oct 28, 2021

Takes my time down from timing out to 1:41.93 when running helmfile apply to my local minikube cluster.

Of course unfortunately it spits out cache minikube deprecation warnings. I'm also slightly worried after reading the docs we might get caught by some bugs in pulling new images (particularly after we starting using mutable rather than unique tags) see: kubernetes/minikube#10060

I'm torn but I suspect we don't actually want to merge this for this reason.

This has worked great for me for the almost two weeks using it, i guess these problems might manifest themselves later.

@toban toban closed this Nov 9, 2021
@toban toban deleted the add-cache-command branch November 9, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants