Run tests on CI server (and locally with npm test) #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As the new release of wikibase data model js lib is meant to be a npm package, those changes are going to be part of the bigger preparation towards making this lib the npm package too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Travis build fails currently due to "ReferenceError: Can't find variable: wikibase" fixed in wmde/WikibaseDataModelJavaScript#69 but is not released yet.
Shortly speaking: wmde/WikibaseDataModelJavaScript#78 needs merge and release, then this lib needs a dependency version bump and test will start to fly.