Skip to content

Start using extension.json and enable PHPCS on Travis #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2017
Merged

Conversation

thiemowmde
Copy link
Contributor

@thiemowmde thiemowmde commented Aug 2, 2017

This patch is intended to do all the following things:

  • Make Travis run PHPCS.
  • Start using the extension.json format. Hooks and resource loader modules are missing, but it's a start.
  • I'm also preparing a release here. But it does not contain anything relevant, so I suggest to not tag the actual release right now. We can do this any time later.

@thiemowmde thiemowmde requested a review from Ladsgroup August 2, 2017 13:44
@Ladsgroup
Copy link
Contributor

Awesome, We have so much technical debt buried in here that I will have nightmares tonight. Can we make a phab card to track migration to extension.json format? Also this, as a mediawiki extension, needs to go to gerrit.

@Ladsgroup Ladsgroup merged commit fbc9f67 into master Aug 2, 2017
@Ladsgroup Ladsgroup deleted the csTravis branch August 2, 2017 15:48
@thiemowmde
Copy link
Contributor Author

This is not an extension. This stuff is only here so the component shows up on Special:Version, for the QUnit tests, and ResourceLoader modules. It might be possible to remove this entirely. At least Special:Version does not need this any more, as far as I know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants