-
Notifications
You must be signed in to change notification settings - Fork 2
expanded the types to include snaks #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Hi! Thanks so much for your PR. I guess you saw that we are tracking bugs on phabricator and the ticket assigned to this has been edited into your PR description. We need to find a little time to review this but I hope we can give you some feedback shortly. Cheers! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No rush I use it for a personal project. but i thought that it would be nice to also provide it here.
I added some comment to part which im not sure about. i'm happy to resolve them my self after I get some input.
hello,
I was looking for wikidata dataformat types and found this.
I expanded the types by adding the api results from wikidata and then adding stuff till it had no errors.
In this process I lost track of what is wikidata and what is wikibase so that is someting that needs to be looked at.
I also removed some simi types like fingerprintable so if there is still a need for that then ill add it again.
I look forward to hearing what you think of the PR.
-wvdp
Bug: https://phabricator.wikimedia.org/T267904