Skip to content

Conversation

wvanderp
Copy link

@wvanderp wvanderp commented Nov 14, 2020

hello,

I was looking for wikidata dataformat types and found this.

I expanded the types by adding the api results from wikidata and then adding stuff till it had no errors.
In this process I lost track of what is wikidata and what is wikibase so that is someting that needs to be looked at.

I also removed some simi types like fingerprintable so if there is still a need for that then ill add it again.

I look forward to hearing what you think of the PR.

-wvdp

Bug: https://phabricator.wikimedia.org/T267904

@tarrow
Copy link
Contributor

tarrow commented Nov 17, 2020

Hi! Thanks so much for your PR.

I guess you saw that we are tracking bugs on phabricator and the ticket assigned to this has been edited into your PR description. We need to find a little time to review this but I hope we can give you some feedback shortly.

Cheers!
Tom

Copy link
Author

@wvanderp wvanderp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No rush I use it for a personal project. but i thought that it would be nice to also provide it here.

I added some comment to part which im not sure about. i'm happy to resolve them my self after I get some input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants