Skip to content

Add some typescript definitions #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2019
Merged

Add some typescript definitions #97

merged 1 commit into from
Oct 24, 2019

Conversation

tarrow
Copy link
Contributor

@tarrow tarrow commented Oct 24, 2019

This is the minimal set of TS definitions currently required by TaintedReferences

@mariushoch
Copy link
Member

Do we have a way to verify these against the JS code (make sure that all things we map out here actually do exist)? If not, I think this is fine as is.

@Ladsgroup
Copy link
Contributor

Do we have a way to verify these against the JS code (make sure that all things we map out here actually do exist)? If not, I think this is fine as is.

It should doable now because of the webpack + karma system we built for testing.

Minimal definitions currently required for TaintedReferences
Copy link
Contributor Author

@tarrow tarrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the repo is currently lacking webpack; it also doesn't have typescript as a devDependency right now.

We could try and implement something for some crude testing but trying to avoid having to work around that was the main reason I didn't put this on DefinitelyTyped. I suggest we don't bother now. If we find that we're always adding types here some check that they are right would be smart though

@Ladsgroup
Copy link
Contributor

I think that the repo is currently lacking webpack;

It doesn't ^_^ look at the karma.conf.js

@Ladsgroup
Copy link
Contributor

the test can be done later.

@Ladsgroup Ladsgroup merged commit 23ccefd into master Oct 24, 2019
@Ladsgroup Ladsgroup deleted the addTRTypes branch October 24, 2019 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants