Skip to content

Use CommonJS modules instead of global namespaces #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2019
Merged

Use CommonJS modules instead of global namespaces #92

merged 1 commit into from
Oct 16, 2019

Conversation

jakobw
Copy link
Member

@jakobw jakobw commented Oct 16, 2019

Bug: T233790

Ladsgroup
Ladsgroup approved these changes Oct 16, 2019
View reviewed changes
Copy link
Contributor

@Ladsgroup Ladsgroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicks:

  • We can remove wikibase from eslintrc
  • We can add the notes to README for new release
  • (Very unrelated) ./src/ReferenceList.js: 'wbDataModelReferenceList' should be 'WbDataModelReferenceList' for consistency

@jakobw
Copy link
Member Author

jakobw commented Oct 16, 2019

@Ladsgroup done, done and done!

@jakobw
Copy link
Member Author

jakobw commented Oct 16, 2019

This patch can be tried in integration with https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/543472 (which is of course still missing the submodule bump)

@Ladsgroup
Copy link
Contributor

Merged, Merged, and Merged

@Ladsgroup Ladsgroup merged commit 35cdb04 into master Oct 16, 2019
@Ladsgroup Ladsgroup deleted the full-lib-mode branch October 16, 2019 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ladsgroup Ladsgroup Ladsgroup approved these changes

@rosalieper rosalieper Awaiting requested review from rosalieper

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakobw @Ladsgroup