Skip to content

Update eslint to be compatible with Wikibase .eslintrc #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2018

Conversation

jakobw
Copy link
Member

@jakobw jakobw commented Jun 22, 2018

Running eslint from extensions/Wikibase/view/lib/wikibase-data-model fails due to the eslint versions being out sync.

> wikibase-data-model@4.0.0 eslint extensions/Wikibase/view/lib/wikibase-data-model
> eslint .

extensions/Wikibase/.eslintrc.json:
	Configuration for rule "indent" is invalid:
	Value "off" is the wrong type.

Error: extensions/Wikibase/.eslintrc.json:
	Configuration for rule "indent" is invalid:
	Value "off" is the wrong type.

@manicki manicki merged commit 93229f5 into master Jun 22, 2018
@manicki manicki deleted the update-eslint branch June 22, 2018 09:57
@manicki
Copy link
Member

manicki commented Jun 22, 2018

shouldn't Wikibase's eslint just ignore all lib directories from linting (same it does not run lib's unit tests etc). Or do I misread the description?

@jakobw
Copy link
Member Author

jakobw commented Jun 22, 2018

@manicki If I understand it correctly, it's the other way around: eslint goes up the directory tree looking for "parent" .eslintrc files to inherit from. An alternative would probably be to set the root: true option to prevent it from doing so https://eslint.org/docs/user-guide/configuring#using-configuration-files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants