Skip to content

Remove dysfunctional convenience methods from Item/Property #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2017

Conversation

thiemowmde
Copy link
Contributor

this._statementGroupSet is, as the name suggests, a StatementGroupSet, which is a Set. The Set class declares both an isEmpty and an equals method, but there is no addStatement or removeStatement anywhere in the code base. Not declared, not tested, and not used anywhere.

To add and remove statements code calls entity.getStatements().addItem( … ) and removeItem( … ), both declared on the Set class.

@thiemowmde thiemowmde added the bug label May 17, 2017
@thiemowmde thiemowmde requested a review from bekh6ex May 17, 2017 09:10
@bekh6ex bekh6ex merged commit acd326d into master May 17, 2017
@thiemowmde thiemowmde deleted the deadStatementCalls branch May 17, 2017 13:42
bekh6ex added a commit that referenced this pull request May 17, 2017
This was referenced Sep 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants