Skip to content

Allow setting Fingerprint terms to null #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2016
Merged

Allow setting Fingerprint terms to null #65

merged 1 commit into from
Aug 1, 2016

Conversation

thiemowmde
Copy link
Contributor

Usually I would avoid "magical" behavior like this. For example, this must not be done in the Map base class. It should be possible to store null in a map. A generic map should not have such a magical value.

But labels, descriptions and aliases do have a specific type.

And most important: The getters return null. The setters should accept everything the getter returns.

@mariushoch
Copy link
Member

Sounds sensible to me and the implementation looks good. Would like another opinion, though.

@thiemowmde thiemowmde modified the milestone: 3.0.0 Aug 1, 2016
@JonasKress JonasKress merged commit 6c0ee19 into master Aug 1, 2016
@JonasKress JonasKress deleted the addNull branch August 1, 2016 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants