Use extension registration for MediaWiki credits #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, but I suggest to rename all LICEN[CS]E files to COPYING, because this file name is way more common across our components. |
|
Also see the discussion at wmde/WikibaseInternalSerialization#91. |
|
+2, but this is a breaking change because of the removal of the constant. We could merge this faster with the constant marked as deprecated. |
|
it is not so urgent to merge this |
and renamed LICENCE file to COPYING also fixes broken license link on Special:Version
thiemowmde
force-pushed
the
mwcredits
branch
from
2f9bd0d to
ccc2c26
Compare
|
I re-added the constant and marked it as deprecated. |
thiemowmde
added a commit
that referenced
this pull request
Feb 10, 2016
Use extension registration for MediaWiki credits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also fixes broken license link on Special:Version