Add support for precision null to GlobeCoordinate #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiemowmde
force-pushed
the
geoPrecisionNull
branch
from
d357585 to
6a16147
Compare
thiemowmde
force-pushed
the
geoPrecisionNull
branch
from
6a16147 to
ca94f16
Compare
|
I just realized this is a duplicate of #91 from more than two months ago. :-( |
This was referenced Apr 8, 2016
Merged
thiemowmde
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before #53 the implementation already supported both null and undefined precisions, but this was never tested properly, only slightly with a lazy
assert.equal( …, null )that acceptsundefinedasnull. #53 broke this feature, but not the test, because it was never callingequalswith an undefined precision.The backend also supports precision null, see https://github.com/DataValues/Geo/blob/master/src/Values/GlobeCoordinateValue.php.