Do not pad year on the client #59

thiemowmde · 2015-01-27T10:10:37Z

This removes the code that pads the year to exactly 11 digits. I do not consider this a breaking change but a bugfix for multiple reasons:

Note how the pad function truncated (!) if the given number was longer than the requested number of digits.
Note how the pad function was unable to correctly pad to more than 11 digits.
Note how nothing of this was ever tested.
Padding should, if required, be done in a single place on the server. The PHP parsers are able to understand ISO time strings with any (1 to 16) number of digits for the year.

adrianheine · 2015-01-27T10:57:51Z

lib/time/time.Time.js

-		return ( 1e12 + Math.abs( number ) + '' ).slice( -digits );
+		number = '' + Math.abs( number );
+
+		if ( number.lenght >= digits ) {


Ouch. Done.

thiemowmde · 2015-03-16T10:38:36Z

Resubmitted as #67 and #71.

Do not pad year on the client

3a6eee8

thiemowmde added the bug label Jan 27, 2015

adrianheine reviewed Jan 27, 2015
View reviewed changes

thiemowmde added 2 commits January 27, 2015 12:22

Fix typo

db027b2

Use String()

8186727

thiemowmde mentioned this pull request Mar 4, 2015

Fix and test the TimeValue.pad() function #67

Merged

thiemowmde closed this Mar 16, 2015

thiemowmde deleted the padding branch March 16, 2015 10:38

Provide feedback