Skip to content

Removed ParseValue API module #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 22, 2014
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions DataValuesJavascript.php
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,6 @@
include( __DIR__ . '/src/valueFormatters/resources.mw.php' )
);

// API module registration
$GLOBALS['wgAPIModules']['parsevalue'] = 'ValueParsers\ApiParseValue';

/**
* @deprecated since 0.1 This is a global registry that provides no control over object lifecycle
*/
$GLOBALS['wgValueParsers'] = array();

/**
* Register QUnit test base classes used by test modules in dependent components.
* @see https://www.mediawiki.org/wiki/Manual:Hooks/ResourceLoaderTestModules
Expand Down
6 changes: 0 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,8 @@ On [Packagist](https://packagist.org/packages/data-values/javascript):

## Technical debt

TODO: remove dependency on ApiParserValue from the JS so ApiParseValue
can be removed. ApiParseValue is the only PHP class in this package and
is the only thing that depends on the DataValues PHP components.

TODO: write high level description and documentation in this README file.

TODO: make tests runnable without needing MW and a browser

TODO: have tests run on CI

## Release notes
Expand Down
6 changes: 1 addition & 5 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,11 @@
"irc": "irc://irc.freenode.net/wikidata"
},
"require": {
"composer/installers": ">=1.0.1",
"data-values/interfaces": "~0.1"
"composer/installers": ">=1.0.1"
},
"autoload": {
"files" : [
"DataValuesJavascript.php"
],
"classmap": [
"php/src/"
]
}
}
337 changes: 0 additions & 337 deletions php/src/ApiParseValue.php

This file was deleted.

4 changes: 2 additions & 2 deletions php/tests/bootstrap.php → phpunit.bootstrap.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
}

$pwd = exec( 'pwd' );
chdir( __DIR__ . '/../..' );
chdir( __DIR__ );
passthru( 'composer update' );
chdir( $pwd );

require_once( __DIR__ . '/../../vendor/autoload.php' );
require_once( __DIR__ . '/vendor/autoload.php' );
Loading