Remove unused getSortKey from DataValue interface #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ladsgroup
approved these changes
Jul 20, 2017
|
Now it has conflicts :/ I also would like some time for more eyes on this as it's a little bit big (but looks trivial) |
thiemowmde
force-pushed
the
deadSortKeys
branch
2 times, most recently
from
339b8d3 to
b2eab29
Compare
thiemowmde
force-pushed
the
deadSortKeys
branch
from
b2eab29 to
9fc6438
Compare
I'm trying to minimize the unused code in this repository for years. Today I finally found a string I can pull without the whole thing breaking apart: Just do a fultext search for "getSortKey" and you will see it is not used anywhere. This will allow us to remove much, much more unused code. I'm focusing on two very small methods here and plan to continue removing more unused code in later patches. * The iso6709 method on the class is unused now. Note there is an other static helper function with the same name and a parameter. That is still used. * _getTimestamp is private anyway. The parameter is unused now.
thiemowmde
force-pushed
the
deadSortKeys
branch
from
9fc6438 to
1573c76
Compare
This was referenced Aug 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to minimize the unused code in this repository for years. Today I finally found a string I can pull without the whole thing breaking apart: Just do a fultext search for "getSortKey" and you will see it is not used anywhere.
This will allow us to remove much, much more unused code. I'm focusing on two very small methods here and plan to continue removing more unused code in later patches.
After this is merged and released, the following patches also must be merged:
Bug: T172916