Skip to content

Use Wikibase's CodeSniffer instead of MediaWiki's #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2017
Merged

Use Wikibase's CodeSniffer instead of MediaWiki's #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"composer/installers": ">=1.0.1"
},
"require-dev": {
"mediawiki/mediawiki-codesniffer": "~0.5"
"wikibase/wikibase-codesniffer": "^0.1.0"
},
"autoload": {
"files" : [
Expand All @@ -38,7 +38,7 @@
},
"scripts": {
"phpcs": [
"vendor/bin/phpcs lib/* src/* --standard=phpcs.xml -sp"
"vendor/bin/phpcs . -sp"
]
}
}
34 changes: 1 addition & 33 deletions phpcs.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,38 +1,6 @@
<?xml version="1.0"?>
<ruleset name="DataValuesJavaScript">
<!-- See https://github.com/wikimedia/mediawiki-tools-codesniffer/blob/master/MediaWiki/ruleset.xml -->
<rule ref="vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
<rule ref="vendor/wikibase/wikibase-codesniffer/Wikibase">
<exclude name="Generic.Arrays.DisallowLongArraySyntax" />
</rule>

<rule ref="Generic.ControlStructures" />
<rule ref="Generic.Files.LineLength">
<properties>
<property name="lineLimit" value="124" />
</properties>
</rule>
<rule ref="Generic.PHP.CharacterBeforePHPOpeningTag" />

<rule ref="PSR1" />
<rule ref="PSR1.Methods.CamelCapsMethodName.NotCamelCaps">
<!-- Exclude test methods like "testGivenInvalidInput_methodThrowsException". -->
<exclude-pattern>tests*Test*\.php</exclude-pattern>
</rule>

<rule ref="PSR2.Files" />

<rule ref="Squiz.Classes.DuplicateProperty" />
<rule ref="Squiz.Classes.SelfMemberReference" />
<rule ref="Squiz.ControlStructures.ControlSignature" />
<rule ref="Squiz.Functions.FunctionDuplicateArgument" />
<rule ref="Squiz.Functions.GlobalFunction" />
<rule ref="Squiz.Scope" />
<rule ref="Squiz.WhiteSpace.FunctionSpacing">
<properties>
<property name="spacing" value="1" />
</properties>
</rule>

<arg name="extensions" value="php" />
<arg name="ignore" value="*\.js" />
</ruleset>