Skip to content

Moved dataValues.util.inherit to util.inherit #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 20, 2014
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .jshintrc
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
"QUnit",
"valueFormatters",
"valueParsers",
"time"
"time",
"util"
]
}
12 changes: 5 additions & 7 deletions DataValues.resources.php
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
),
'dependencies' => array(
'dataValues',
'dataValues.util',
'util.inherit',
),
),

Expand All @@ -60,20 +60,18 @@
),
'dependencies' => array(
'dataValues.DataValue',
'util.inherit',
'globeCoordinate.js', // required by GlobeCoordinateValue
'time.js' // required by TimeValue
),
),

'dataValues.util' => $moduleTemplate + array(
'util.inherit' => $moduleTemplate + array(
'scripts' => array(
'dataValues.util.js',
'dataValues.util.inherit.js',
),
'dependencies' => array(
'dataValues',
'../lib/util/util.inherit.js',
),
),

);

} );
Expand Down
12 changes: 6 additions & 6 deletions DataValues.tests.qunit.php
Original file line number Diff line number Diff line change
Expand Up @@ -54,18 +54,18 @@
),
'dependencies' => array(
'dataValues.DataValue.tests',
'dataValues.values'
'dataValues.values',
'util.inherit',
),
),

'dataValues.util.tests' => array(
'util.inherit.tests' => array(
'scripts' => array(
"$bp/util.inherit/inherit.testWithDifferentArguments.js",
"$bp/util.inherit/inherit.testConstructorNames.js",
"$bp/util.inherit/inherit.testGeneratedConstructorNames.js",
"$bp/lib/util/util.inherit.tests.js",
),
'dependencies' => array(
'dataValues.util',
'jquery',
'util.inherit',
),
),

Expand Down
2 changes: 2 additions & 0 deletions DataValuesJavascript.php
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@
),
'dependencies' => array(
'ext.valueParsers.tests',
'util.inherit',
),
);

Expand Down Expand Up @@ -165,6 +166,7 @@
),
'dependencies' => array(
'ext.valueFormatters.tests',
'util.inherit',
'valueFormatters.formatters',
),
);
Expand Down
12 changes: 1 addition & 11 deletions js/ValueFormatters.resources.php
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
),
'dependencies' => array(
'valueFormatters',
'valueFormatters.util',
),
),

Expand All @@ -51,20 +50,11 @@
),
'dependencies' => array(
'dataValues.values',
'util.inherit',
'valueFormatters.ValueFormatter',
),
),

'valueFormatters.util' => $moduleTemplate + array(
'scripts' => array(
'valueFormatters.util.js',
),
'dependencies' => array(
'dataValues.util',
'valueFormatters',
),
),

);

} );
13 changes: 2 additions & 11 deletions js/ValueParsers.resources.php
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@
'parsers/ApiBasedValueParser.js',
),
'dependencies' => array(
'util.inherit',
'valueParsers',
'valueParsers.util',
),
),

Expand All @@ -60,23 +60,14 @@
'parsers/NullParser.js',
),
'dependencies' => array(
'util.inherit',
'valueParsers.ValueParser',
'valueParsers.api',
'globeCoordinate.js', // required by GlobeCoordinateParser
'time.js', // required by TimeParser
),
),

'valueParsers.util' => $moduleTemplate + array(
'scripts' => array(
'valueParsers.util.js',
),
'dependencies' => array(
'dataValues.util',
'valueParsers',
),
),

'valueParsers.api' => $moduleTemplate + array(
'scripts' => array(
'valueParsers.Api.js',
Expand Down
6 changes: 3 additions & 3 deletions js/src/ValueFormatters/formatters/NullFormatter.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* @licence GNU GPL v2+
* @author H. Snater < mediawiki@snater.com >
*/
( function( $, vf, dv ) {
( function( $, vf, dv, util ) {
'use strict';

var PARENT = vf.ValueFormatter;
Expand All @@ -19,7 +19,7 @@
* @extends valueFormatters.ValueFormatter
* @since 0.1
*/
vf.NullFormatter = vf.util.inherit( PARENT, function() {}, {
vf.NullFormatter = util.inherit( PARENT, function() {}, {
/**
* @see valueFormatters.ValueFormatter.format
*/
Expand All @@ -45,4 +45,4 @@

} );

}( jQuery, valueFormatters, dataValues ) );
}( jQuery, valueFormatters, dataValues, util ) );
6 changes: 3 additions & 3 deletions js/src/ValueFormatters/formatters/StringFormatter.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* @licence GNU GPL v2+
* @author H. Snater < mediawiki@snater.com >
*/
( function( $, vf ) {
( function( $, vf, util ) {
'use strict';

var PARENT = vf.ValueFormatter;
Expand All @@ -13,7 +13,7 @@
* @extends valueFormatters.ValueFormatter
* @since 0.1
*/
vf.StringFormatter = vf.util.inherit( PARENT, {
vf.StringFormatter = util.inherit( PARENT, {
/**
* @see valueFormatters.ValueFormatter.format
* @since 0.1
Expand All @@ -30,4 +30,4 @@
}
} );

}( jQuery, valueFormatters ) );
}( jQuery, valueFormatters, util ) );
6 changes: 3 additions & 3 deletions js/src/ValueFormatters/formatters/ValueFormatter.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* @licence GNU GPL v2+
* @author H. Snater < mediawiki@snater.com >
*/
( function( $, vf ) {
( function( $, vf, util ) {
'use strict';

/**
Expand Down Expand Up @@ -54,8 +54,8 @@
* - {string|null} Formatted DataValue.
* - {dataValues.DataValue|null} DataValue object that has been formatted.
*/
format: vf.util.abstractMember
format: util.abstractMember

} );

}( jQuery, valueFormatters ) );
}( jQuery, valueFormatters, util ) );
27 changes: 0 additions & 27 deletions js/src/ValueFormatters/valueFormatters.util.js

This file was deleted.

10 changes: 3 additions & 7 deletions js/src/ValueParsers/parsers/ApiBasedValueParser.js
Original file line number Diff line number Diff line change
@@ -1,12 +1,8 @@
/**
* @file
* @ingroup ValueParsers
*
* @licence GNU GPL v2+
*
* @author Daniel Werner < danweetz@web.de >
*/
( function( vp, dv, $ ) {
( function( vp, dv, $, util ) {
'use strict';

var PARENT = vp.ValueParser;
Expand All @@ -20,7 +16,7 @@
* @abstract
* @since 0.1
*/
vp.ApiBasedValueParser = dv.util.inherit( 'VpApiBasedValueParser', PARENT, {
vp.ApiBasedValueParser = util.inherit( 'VpApiBasedValueParser', PARENT, {
/**
* The key of the related API parser.
* @type String
Expand Down Expand Up @@ -51,4 +47,4 @@

} );

}( valueParsers, dataValues, jQuery ) );
}( valueParsers, dataValues, jQuery, util ) );
10 changes: 3 additions & 7 deletions js/src/ValueParsers/parsers/BoolParser.js
Original file line number Diff line number Diff line change
@@ -1,12 +1,8 @@
/**
* @file
* @ingroup ValueParsers
*
* @licence GNU GPL v2+
*
* @author Jeroen De Dauw < jeroendedauw@gmail.com >
*/
( function( vp, dv, $, undefined ) {
( function( vp, dv, util ) {
'use strict';

var PARENT = vp.ApiBasedValueParser;
Expand All @@ -18,11 +14,11 @@
* @extends vp.ApiBasedValueParser
* @since 0.1
*/
vp.BoolParser = dv.util.inherit( PARENT, {
vp.BoolParser = util.inherit( PARENT, {
/**
* @see ApiBasedValueParser.API_VALUE_PARSER_ID
*/
API_VALUE_PARSER_ID: 'bool'
} );

}( valueParsers, dataValues, jQuery ) );
}( valueParsers, dataValues, util ) );
10 changes: 3 additions & 7 deletions js/src/ValueParsers/parsers/FloatParser.js
Original file line number Diff line number Diff line change
@@ -1,12 +1,8 @@
/**
* @file
* @ingroup ValueParsers
*
* @licence GNU GPL v2+
*
* @author Daniel Werner < danweetz@web.de >
*/
( function( vp, dv, $, undefined ) {
( function( vp, dv, util ) {
'use strict';

var PARENT = vp.ApiBasedValueParser;
Expand All @@ -18,11 +14,11 @@
* @extends vp.ApiBasedValueParser
* @since 0.1
*/
vp.FloatParser = dv.util.inherit( PARENT, {
vp.FloatParser = util.inherit( PARENT, {
/**
* @see ApiBasedValueParser.API_VALUE_PARSER_ID
*/
API_VALUE_PARSER_ID: 'float'
} );

}( valueParsers, dataValues, jQuery ) );
}( valueParsers, dataValues, util ) );
10 changes: 3 additions & 7 deletions js/src/ValueParsers/parsers/GlobeCoordinateParser.js
Original file line number Diff line number Diff line change
@@ -1,12 +1,8 @@
/**
* @file
* @ingroup ValueParsers
*
* @licence GNU GPL v2+
*
* @author H. Snater < mediawiki@snater.com >
*/
( function( vp, dv ) {
( function( vp, dv, util ) {
'use strict';

var PARENT = vp.ApiBasedValueParser;
Expand All @@ -18,11 +14,11 @@
* @extends vp.ApiBasedValueParser
* @since 0.1
*/
vp.GlobeCoordinateParser = dv.util.inherit( PARENT, {
vp.GlobeCoordinateParser = util.inherit( PARENT, {
/**
* @see vp.ApiBasedValueParser.API_VALUE_PARSER_ID
*/
API_VALUE_PARSER_ID: 'globecoordinate'
} );

}( valueParsers, dataValues ) );
}( valueParsers, dataValues, util ) );
10 changes: 3 additions & 7 deletions js/src/ValueParsers/parsers/IntParser.js
Original file line number Diff line number Diff line change
@@ -1,12 +1,8 @@
/**
* @file
* @ingroup ValueParsers
*
* @licence GNU GPL v2+
*
* @author Jeroen De Dauw < jeroendedauw@gmail.com >
*/
( function( vp, dv, $, undefined ) {
( function( vp, dv, util ) {
'use strict';

var PARENT = vp.ApiBasedValueParser;
Expand All @@ -18,11 +14,11 @@
* @extends vp.ApiBasedValueParser
* @since 0.1
*/
vp.IntParser = dv.util.inherit( PARENT, {
vp.IntParser = util.inherit( PARENT, {
/**
* @see ApiBasedValueParser.API_VALUE_PARSER_ID
*/
API_VALUE_PARSER_ID: 'int'
} );

}( valueParsers, dataValues, jQuery ) );
}( valueParsers, dataValues, util ) );
Loading